Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use UTF8 PostMethod everywhere #5614

Merged
merged 1 commit into from
Mar 10, 2020
Merged

Use UTF8 PostMethod everywhere #5614

merged 1 commit into from
Mar 10, 2020

Conversation

tobiasKaminsky
Copy link
Member

Fix #5416

Signed-off-by: tobiasKaminsky [email protected]

Signed-off-by: tobiasKaminsky <[email protected]>
@tobiasKaminsky
Copy link
Member Author

/backport to stable-3.11

@nextcloud-android-bot
Copy link
Collaborator

@nextcloud-android-bot
Copy link
Collaborator

APK file: https://www.kaminsky.me/nc-dev/android-artifacts/13000.apk

qrcode

To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud app.

@nextcloud-android-bot
Copy link
Collaborator

Codacy

375

Lint

TypemasterPR
Warnings9696
Errors00

SpotBugs (new)

Warning TypeNumber
Bad practice Warnings26
Correctness Warnings70
Internationalization Warnings13
Malicious code vulnerability Warnings5
Multithreaded correctness Warnings9
Performance Warnings77
Security Warnings44
Dodgy code Warnings141
Total385

SpotBugs (master)

Warning TypeNumber
Bad practice Warnings26
Correctness Warnings70
Internationalization Warnings13
Malicious code vulnerability Warnings5
Multithreaded correctness Warnings9
Performance Warnings77
Security Warnings44
Dodgy code Warnings141
Total385

@codecov
Copy link

codecov bot commented Mar 10, 2020

Codecov Report

Merging #5614 into master will increase coverage by 0.12%.
The diff coverage is 58.16%.

@@             Coverage Diff              @@
##             master    #5614      +/-   ##
============================================
+ Coverage     24.38%   24.51%   +0.12%     
  Complexity        3        3              
============================================
  Files           397      401       +4     
  Lines         33946    34003      +57     
  Branches       4718     4728      +10     
============================================
+ Hits           8278     8336      +58     
+ Misses        24377    24376       -1     
  Partials       1291     1291              
Impacted Files Coverage Δ Complexity Δ
...m/nextcloud/client/account/UserAccountManager.java 33.33% <ø> (ø) 0.00 <0.00> (ø)
...android/files/CreateFileFromTemplateOperation.java 0.00% <0.00%> (ø) 0.00 <0.00> (ø)
...ncloud/android/files/StreamMediaFileOperation.java 0.00% <0.00%> (ø) 0.00 <0.00> (ø)
...ava/com/owncloud/android/jobs/NotificationJob.java 0.00% <0.00%> (ø) 0.00 <0.00> (ø)
.../operations/RichDocumentsCreateAssetOperation.java 0.00% <0.00%> (ø) 0.00 <0.00> (ø)
.../android/operations/RichDocumentsUrlOperation.java 0.00% <0.00%> (ø) 0.00 <0.00> (ø)
...d/ui/asynctasks/NotificationExecuteActionTask.java 0.00% <0.00%> (ø) 0.00 <0.00> (ø)
.../dialog/SyncedFolderPreferencesDialogFragment.java 0.00% <0.00%> (ø) 0.00 <0.00> (ø)
...android/ui/fragment/FileDetailSharingFragment.java 0.00% <0.00%> (ø) 0.00 <0.00> (ø)
...ncloud/android/ui/preview/PreviewTextFragment.java 62.82% <0.00%> (ø) 0.00 <0.00> (ø)
... and 24 more

@backportbot-nextcloud
Copy link

backport to stable-3.11 in #5621

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

creating files with special characters fails
3 participants