Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Caching adjustments. Refactoring, use service layers with caching #14

Merged
merged 29 commits into from
Jul 22, 2023

Conversation

andrey18106
Copy link
Collaborator

@andrey18106 andrey18106 commented Jul 17, 2023

Changes:

  • remove last_response_time and related functions
  • rename last_response_time->last_check_time usage (getExApps) in nc_py_api @bigcat88
  • add docker container healthcheck before heartbeat exApp in deployment process @andrey18106
  • add php lint, cs, psalm, security cheks ci @andrey18106
  • review caches usage
  • review exception handling and logging
  • add ci for tests with redis
  • php-cs fixes
  • update apis response statuses for nc_py_api tests
  • fix caching issues (if any)

Copy link
Member

@bigcat88 bigcat88 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we need to add php linters, they will automatically find such errors

@andrey18106 andrey18106 changed the title Caching adjustments. Refactoring, use service layer with cache for ot… Caching adjustments. Refactoring, use service layers with caching Jul 18, 2023
@github-advanced-security
Copy link

This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation.

@bigcat88
Copy link
Member

I merge this, as this is already an abnormally big PR

@bigcat88 bigcat88 merged commit 3ff978e into main Jul 22, 2023
14 of 17 checks passed
@bigcat88 bigcat88 deleted the caching-refactoring branch July 22, 2023 11:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants