Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a UI for the Nextcloud CalDAV trashbin #3118

Merged
merged 1 commit into from
May 31, 2021
Merged

Conversation

ChristophWurst
Copy link
Member

@ChristophWurst ChristophWurst commented May 28, 2021

This adds a UI to list and restore deleted calendars and calendar objects, as discussed in nextcloud/server#1662.

Todo

@codecov
Copy link

codecov bot commented May 28, 2021

Codecov Report

Merging #3118 (b0e1a01) into master (d358987) will decrease coverage by 0.44%.
The diff coverage is 3.60%.

❗ Current head b0e1a01 differs from pull request most recent head ba0d245. Consider uploading reports for the commit ba0d245 to get more accurate results
Impacted file tree graph

@@             Coverage Diff              @@
##             master    #3118      +/-   ##
============================================
- Coverage     29.41%   28.97%   -0.45%     
  Complexity      121      121              
============================================
  Files           155      157       +2     
  Lines          5609     5705      +96     
  Branches        826      836      +10     
============================================
+ Hits           1650     1653       +3     
- Misses         3959     4052      +93     
Flag Coverage Δ
javascript 23.49% <3.60%> (-0.38%) ⬇️
php 94.54% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...NavigationHeader/AppNavigationHeaderDatePicker.vue 0.00% <0.00%> (ø)
...c/components/AppNavigation/CalendarList/Moment.vue 0.00% <0.00%> (ø)
...components/AppNavigation/CalendarList/Trashbin.vue 0.00% <0.00%> (ø)
src/store/calendars.js 0.00% <0.00%> (ø)
src/views/Calendar.vue 0.00% <0.00%> (ø)
src/views/Dashboard.vue 0.00% <ø> (ø)
src/services/caldavService.js 29.82% <23.07%> (+0.97%) ⬆️
src/services/windowTitleService.js 95.65% <50.00%> (-4.35%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d358987...ba0d245. Read the comment docs.

@ChristophWurst

This comment has been minimized.

@ChristophWurst ChristophWurst marked this pull request as ready for review May 31, 2021 19:08
@ChristophWurst ChristophWurst self-assigned this May 31, 2021
@ChristophWurst ChristophWurst added 3. to review Waiting for reviews and removed 2. developing Work in progress labels May 31, 2021
@ChristophWurst ChristophWurst modified the milestones: v2.2.3, v2.3.0 May 31, 2021
@ChristophWurst ChristophWurst merged commit 0d6baaf into master May 31, 2021
@delete-merged-branch delete-merged-branch bot deleted the feature/trashbin branch May 31, 2021 19:13
@ChristophWurst ChristophWurst added the Feature: Trash bin Deleted calendars, events and other objects in the caldav trash bin UI label Jun 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews enhancement New feature request Feature: Trash bin Deleted calendars, events and other objects in the caldav trash bin UI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants