Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

InviteesListSearch: make avatar status not clip #6246

Merged
merged 1 commit into from
Aug 19, 2024

Conversation

GVodyanov
Copy link
Contributor

Fix #6227

After Before
image image

The culprit was NcSelect styling (as per usual)

@GVodyanov GVodyanov added the 3. to review Waiting for reviews label Aug 8, 2024
@GVodyanov GVodyanov self-assigned this Aug 8, 2024
Copy link

codecov bot commented Aug 8, 2024

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 23.88%. Comparing base (2af617b) to head (3cfb3a2).
Report is 87 commits behind head on main.

Files with missing lines Patch % Lines
.../components/Editor/Invitees/InviteesListSearch.vue 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main    #6246      +/-   ##
============================================
+ Coverage     23.67%   23.88%   +0.20%     
+ Complexity      457      454       -3     
============================================
  Files           249      246       -3     
  Lines         11774    11655     -119     
  Branches       2203     2189      -14     
============================================
- Hits           2788     2784       -4     
+ Misses         8669     8556     -113     
+ Partials        317      315       -2     
Flag Coverage Δ
javascript 15.45% <0.00%> (+0.19%) ⬆️
php 59.53% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@GVodyanov GVodyanov requested a review from hamza221 August 9, 2024 10:01
@GVodyanov GVodyanov merged commit a9040d7 into main Aug 19, 2024
31 of 33 checks passed
@GVodyanov GVodyanov deleted the fix/avatar-clipping-invitees branch August 19, 2024 11:44
@ChristophWurst
Copy link
Member

/backport to stable5.0

@backportbot backportbot bot added the backport-request A backport was requested for this pull request label Sep 9, 2024
@backportbot backportbot bot removed the backport-request A backport was requested for this pull request label Sep 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Avatar icon has cut off status icon
3 participants