Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FullCalendar CSS: make events in weekly view have the correct width #6269

Merged
merged 1 commit into from
Aug 19, 2024

Conversation

GVodyanov
Copy link
Contributor

Fix #6226

The solution is a bit hacky, but I can't think of anything better...

Before After
image image

@GVodyanov GVodyanov added the 3. to review Waiting for reviews label Aug 19, 2024
@GVodyanov GVodyanov self-assigned this Aug 19, 2024
Copy link

codecov bot commented Aug 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 23.88%. Comparing base (3cfb3a2) to head (0dad0f8).
Report is 34 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##               main    #6269   +/-   ##
=========================================
  Coverage     23.88%   23.88%           
  Complexity      454      454           
=========================================
  Files           246      246           
  Lines         11655    11655           
  Branches       2189     2199   +10     
=========================================
  Hits           2784     2784           
+ Misses         8556     8555    -1     
- Partials        315      316    +1     
Flag Coverage Δ
javascript 15.45% <ø> (ø)
php 59.53% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@miaulalala miaulalala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you test this on mobile?

@GVodyanov
Copy link
Contributor Author

Did you test this on mobile?

Yeah, It's not always pixel perfect, but it works

@miaulalala miaulalala merged commit 34c8f1d into main Aug 19, 2024
36 checks passed
@miaulalala miaulalala deleted the fix/weekly-view-layout branch August 19, 2024 17:42
@miaulalala
Copy link
Contributor

/backport to stable5.0

@backportbot backportbot bot added the backport-request A backport was requested for this pull request label Aug 19, 2024
@backportbot backportbot bot removed the backport-request A backport was requested for this pull request label Aug 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Event bar is too short and has visible background "shadow"
2 participants