Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: added required composer package for psalm #6435

Closed
wants to merge 1 commit into from

Conversation

SebastianKrupinski
Copy link
Contributor

psalm was failing to run due to missing package.

image

Copy link

codecov bot commented Oct 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 15.08%. Comparing base (13545a6) to head (79c87ff).
Report is 14 commits behind head on main.

❗ There is a different number of reports uploaded between BASE (13545a6) and HEAD (79c87ff). Click for more details.

HEAD has 3 uploads less than BASE
Flag BASE (13545a6) HEAD (79c87ff)
php 3 0
Additional details and impacted files
@@             Coverage Diff              @@
##               main    #6435      +/-   ##
============================================
- Coverage     23.56%   15.08%   -8.48%     
============================================
  Files           247      206      -41     
  Lines         11693     9464    -2229     
  Branches       2205     2206       +1     
============================================
- Hits           2755     1428    -1327     
+ Misses         8618     7716     -902     
  Partials        320      320              
Flag Coverage Δ
javascript 15.08% <ø> (ø)
php ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@st3iny st3iny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We omit the OCP package on purpose because it

  1. pollutes the autoloader,
  2. is hard to keep in sync,
  3. and will be installed automatically during CI.

You can run the following command install the package before running psalm:
composer require --dev nextcloud/ocp:dev-master --ignore-platform-reqs --with-dependencies

You can also run it against stable30 by replacing dev-master with dev-stable30 etc.

@SebastianKrupinski
Copy link
Contributor Author

We omit the OCP package on purpose because it

Okay, I was not aware. I will close/delete this then.

@SebastianKrupinski SebastianKrupinski deleted the fix/psalm-requirement branch October 29, 2024 12:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews
Projects
Status: ☑️ Done
Development

Successfully merging this pull request may close these issues.

2 participants