Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Entity parameter types #6436

Merged
merged 1 commit into from
Oct 29, 2024
Merged

fix: Entity parameter types #6436

merged 1 commit into from
Oct 29, 2024

Conversation

SebastianKrupinski
Copy link
Contributor

Psalm was failing on the entity parameter types.

image

Signed-off-by: SebastianKrupinski <[email protected]>
Copy link

codecov bot commented Oct 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 23.56%. Comparing base (13545a6) to head (c413f8d).
Report is 12 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##               main    #6436   +/-   ##
=========================================
  Coverage     23.56%   23.56%           
  Complexity      454      454           
=========================================
  Files           247      247           
  Lines         11693    11693           
  Branches       2205     2206    +1     
=========================================
  Hits           2755     2755           
  Misses         8618     8618           
  Partials        320      320           
Flag Coverage Δ
javascript 15.08% <ø> (ø)
php 59.53% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ChristophWurst
Copy link
Member

See nextcloud/server#47329 (comment). 'int' might return.

Copy link
Member

@st3iny st3iny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@st3iny st3iny merged commit 5387af0 into main Oct 29, 2024
36 checks passed
@st3iny st3iny deleted the fix/entity-types branch October 29, 2024 08:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews
Projects
Status: ☑️ Done
Development

Successfully merging this pull request may close these issues.

3 participants