Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove some dead code and fix a typo #6451

Merged
merged 1 commit into from
Oct 30, 2024

Conversation

st3iny
Copy link
Member

@st3iny st3iny commented Oct 30, 2024

No description provided.

@st3iny st3iny added the 3. to review Waiting for reviews label Oct 30, 2024
@st3iny st3iny requested a review from hamza221 October 30, 2024 08:48
@st3iny st3iny self-assigned this Oct 30, 2024
Copy link

codecov bot commented Oct 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 23.48%. Comparing base (c413f8d) to head (6a5aee7).
Report is 14 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #6451      +/-   ##
============================================
- Coverage     23.56%   23.48%   -0.08%     
  Complexity      454      454              
============================================
  Files           247      247              
  Lines         11693    11705      +12     
  Branches       2206     2222      +16     
============================================
- Hits           2755     2749       -6     
- Misses         8618     8636      +18     
  Partials        320      320              
Flag Coverage Δ
javascript 15.06% <ø> (-0.03%) ⬇️
php 59.42% <ø> (-0.11%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@st3iny st3iny force-pushed the chore/improve-reference-listener branch from 49054ec to 2844372 Compare October 30, 2024 14:07
@st3iny st3iny force-pushed the chore/improve-reference-listener branch from 2844372 to 6a5aee7 Compare October 30, 2024 14:08
@st3iny st3iny changed the title chore: remove some dead code and improve styling in the reference listener chore: remove some dead code and fix a typo Oct 30, 2024
@st3iny st3iny merged commit f073169 into main Oct 30, 2024
35 of 36 checks passed
@st3iny st3iny deleted the chore/improve-reference-listener branch October 30, 2024 15:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants