Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change fill to white to match other icons. #971

Closed
wants to merge 1 commit into from

Conversation

rexbron
Copy link

@rexbron rexbron commented Mar 15, 2022

Fixes #703

@juliushaertl
Copy link
Member

The dark icon would still be needed, so maybe you can put it as circles-dark.svg and make sure that it is used in the places where the current one was used before:

lib/Notification/Notifier.php
150: $iconPath = $this->urlGenerator->imagePath(Application::APP_ID, 'circles.svg');

lib/Activity/Filter.php
54: $this->url->imagePath(Application::APP_ID, 'circles.svg')

lib/UnifiedSearch/UnifiedSearchProvider.php
163: $iconPath = $this->urlGenerator->imagePath(Application::APP_ID, 'circles.svg');

lib/Model/ShareWrapper.php
688: $urlGenerator->imagePath(Application::APP_ID, 'circles.svg')

@rexbron
Copy link
Author

rexbron commented Mar 17, 2022

@juliushaertl Hi!

A separate icon for a dark theme is not required; the dark theme expects a pure white filled icon which it then styles:

image

image

This behavior is consistent with other 1st party apps in Nextcloud.

@juliushaertl
Copy link
Member

It is not about the dark theme but other places where the icon is used like notifications or activity. There a dark icon variant would still be required.

@blizzz blizzz added this to the Nextcloud 25 milestone Apr 21, 2022
@blizzz blizzz modified the milestones: Nextcloud 25, Nextcloud 26 Sep 22, 2022
@blizzz blizzz modified the milestones: Nextcloud 26, Nextcloud 27 Mar 9, 2023
@blizzz blizzz modified the milestones: Nextcloud 27, Nextcloud 28 May 23, 2023
@Altahrim
Copy link

Done in another PR

@Altahrim Altahrim closed this Mar 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Icon in settings
4 participants