chore: Add SPDX headers #1392
Merged
chore: Add SPDX headers #1392
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jonas <[email protected]>
mejo-
force-pushed
the
chore/spdx
branch
2 times, most recently
from
6bd4842
to
12413d7
Compare
3 failed and 2 flaky tests on run #1744 ↗︎
Details:
|
|||||||||||||||||||||||||||||||||||||||||||||
| Test | Artifacts | |
|---|---|---|
| Pages > Creating a page from template > New page has template content |
Screenshots
|
|
page-details.spec.js • 1 failed test • Nextcloud master
| Test | Artifacts | |
|---|---|---|
| Page details > Display table of contents > Allows to display/close TOC and switch page modes in between |
Screenshots
|
|
page-landingpage.spec.js • 1 failed test • Nextcloud stable27
| Test | Artifacts | |
|---|---|---|
| Page landing page > Displays recent pages > Allows to open page from recent pages widget |
Screenshots
|
|
page-list.spec.js • 1 flaky test • Nextcloud stable27
| Test | Artifacts | |
|---|---|---|
| Page list > Page trash > allows to trash and restore page with subpage and attachment |
Screenshots
|
|
page-details.spec.js • 1 flaky test • Nextcloud stable27
| Test | Artifacts | |
|---|---|---|
| Page details > Display table of contents > Allows to display/close TOC and switch page modes in between |
Screenshots
|
|
Review all test suite changes for PR #1392 ↗︎
AndyScherzinger
approved these changes
Jul 29, 2024
There was a problem hiding this comment.
Nice work @mejo-
The remaining items are mostly to be tackled via .license files and a REUSE.toml
Can be done via follow-up PR. I am happy to do thin in my evening hobby time 😃
Other than that: Looks good 👍
mejo-
force-pushed
the
chore/spdx
branch
2 times, most recently
from
6ed4181
to
5592a83
Compare
Fixes: #1367 Signed-off-by: Jonas <[email protected]>
Thanks @AndyScherzinger 🙏 I made the reuse CI job pass now, so hope I caught all the remainers. Still follow-up PRs are much appreciated if you still spot anything 😊 |
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🏁 Checklist
npm run lint/npm run stylelint/composer run cs:check)