Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Navigation): use NcAppNavigationNew for new button #1429

Merged
merged 1 commit into from
Aug 20, 2024

Conversation

mejo-
Copy link
Member

@mejo- mejo- commented Aug 20, 2024

Also put the button into an li element.

Fixes: #1382

πŸ–ΌοΈ Screenshots

🏚️ Before 🏑 After
grafik grafik

🏁 Checklist

  • Code is properly formatted (npm run lint / npm run stylelint / composer run cs:check)
  • Sign-off message is added to all commits

@mejo- mejo- added bug Something isn't working 3. to review labels Aug 20, 2024
@mejo- mejo- self-assigned this Aug 20, 2024
Also put the button into an `li` element.

Fixes: #1382

Signed-off-by: Jonas <[email protected]>
@mejo- mejo- merged commit b2843bb into main Aug 20, 2024
47 of 50 checks passed
@mejo- mejo- deleted the fix/nav_new_button branch August 20, 2024 12:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review bug Something isn't working
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

"New collective" <button> element inside <ul>
2 participants