Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(PageList): Sort numbers numeric (2 > 10) #1459

Merged
merged 1 commit into from
Sep 4, 2024
Merged

fix(PageList): Sort numbers numeric (2 > 10) #1459

merged 1 commit into from
Sep 4, 2024

Conversation

mejo-
Copy link
Member

@mejo- mejo- commented Sep 4, 2024

Fixes: #1447

🏁 Checklist

  • Code is properly formatted (npm run lint / npm run stylelint / composer run cs:check)
  • Sign-off message is added to all commits
  • Tests (unit, integration and/or end-to-end) passing and the changes are covered with tests

@mejo- mejo- added bug Something isn't working 3. to review labels Sep 4, 2024
@mejo- mejo- self-assigned this Sep 4, 2024
@mejo- mejo- requested a review from elzody September 4, 2024 13:36
enjeck
enjeck approved these changes Sep 4, 2024
View reviewed changes
Copy link

@enjeck enjeck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool

@mejo- mejo- merged commit df90a98 into main Sep 4, 2024
48 of 50 checks passed
@mejo- mejo- deleted the fix/sort_pages_by_title_numeric branch September 4, 2024 14:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@enjeck enjeck enjeck approved these changes

@luka-nextcloud luka-nextcloud Awaiting requested review from luka-nextcloud

@elzody elzody Awaiting requested review from elzody

Assignees

@mejo- mejo-

Labels
3. to review bug Something isn't working
Projects
📝 Office team
Status: ☑️ Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Sorting page "A to Z" don't order correctly numbers 1, 10, 11, 12, ..., 2, 3, 4..., 9
2 participants
@mejo- @enjeck