fix: search highlighting persists between pages #1462
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elzody
force-pushed
the
fix/highlight-switch-pages
branch
from
83a3047
to
b24ae0f
Compare
|
@elzody no need to backport, we don't have separate branches for supported Nextcloud versions in Collectives 😉 |
mejo-
requested changes
Sep 5, 2024
mejo-
force-pushed
the
fix/highlight-switch-pages
branch
from
b24ae0f
to
20e6e15
Compare
mejo-
approved these changes
Sep 10, 2024
Signed-off-by: Elizabeth Danzberger <[email protected]> Signed-off-by: Jonas <[email protected]>
`position: absolute` has unwanted drawbacks. `width: 100%` means the full monitor width there - which breaks the design if the browser is not in full screen mode - or if you have developer tools open. Signed-off-by: Jonas <[email protected]>
mejo-
force-pushed
the
fix/highlight-switch-pages
branch
from
20e6e15
to
bfb69b3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📝 Summary
Previously, the search highlighting did not persist when changing pages. This PR uses changes in the editor content to re-execute the search, meaning it should now re-apply the search highlighting properly when switching pages.
🏁 Checklist
npm run lint/npm run stylelint/composer run cs:check)