Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(member): close actions menu when scrolling members #1505

Merged
merged 1 commit into from
Sep 25, 2024

Conversation

mejo-
Copy link
Member

@mejo- mejo- commented Sep 25, 2024

🏁 Checklist

  • Code is properly formatted (npm run lint / npm run stylelint / composer run cs:check)
  • Sign-off message is added to all commits

@mejo- mejo- added bug Something isn't working papercut ui/ux 3. to review labels Sep 25, 2024
@mejo- mejo- self-assigned this Sep 25, 2024
Copy link
Member

@nickvergessen nickvergessen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

At least prevents the menu from being visible while scrolled away.
But could also set the container/parent (@Antreesy might be able to point you into the right places)

@mejo- mejo- force-pushed the fix/close_member_actions_on_scroll branch from 4cf1ec5 to eda0119 Compare September 25, 2024 09:19
@Antreesy
Copy link

container is needed to mount popover in specific place (useful for popover inside of modal to keep correct order): https://floating-vue.starpad.dev/api/#container

boundary (boundaries-element in NcActions) fits better here, but i haven't tested it yet with scrolling lists: https://floating-vue.starpad.dev/api/#boundary

@mejo-
Copy link
Member Author

mejo- commented Sep 25, 2024

boundary (boundaries-element in NcActions) fits better here, but i haven't tested it yet with scrolling lists: https://floating-vue.starpad.dev/api/#boundary

That would probably be $parent.$parent.refs.memberPickerList (the div.member-picker-list element) in this case as it's the one that has the scroll container. Unfortunately passing this as :boundaries-element property to NcActions doesn't solve the problem at hand.

@mejo- mejo- merged commit 3888b66 into main Sep 25, 2024
48 of 50 checks passed
@mejo- mejo- deleted the fix/close_member_actions_on_scroll branch September 25, 2024 10:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: ☑️ Done
Development

Successfully merging this pull request may close these issues.

3 participants