Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: ignored files always show state 'sync pending' #5524

Closed
5 of 8 tasks
PhilippSchlesinger opened this issue Mar 14, 2023 · 2 comments · Fixed by #5853
Closed
5 of 8 tasks

[Bug]: ignored files always show state 'sync pending' #5524

PhilippSchlesinger opened this issue Mar 14, 2023 · 2 comments · Fixed by #5853

Comments

@PhilippSchlesinger
Copy link

PhilippSchlesinger commented Mar 14, 2023

⚠️ Before submitting, please verify the following: ⚠️

Bug description

ignored files always show state 'sync pending'

Steps to reproduce

  1. have some files that are ignored from sync per configuration.
    grafik

  2. look at some of those files in Windows Explorer:
    grafik

  3. the files show 'sync pending' while hovering and in status line. The status icon is also suggesting 'sync pending'.

Expected behavior

File status and icon should somehow show that this file is exempted from sync.
Icon could be corresponding to the tray window
(
grafik
)

Which files are affected by this bug

all files that are ignored by configuration

Operating system

Windows

Which version of the operating system you are running.

Windows 10

Package

Other

Nextcloud Server version

25.0.4

Nextcloud Desktop Client version

3.7.4

Is this bug present after an update or on a fresh install?

Updated from a minor version (ex. 3.4.2 to 3.4.4)

Are you using the Nextcloud Server Encryption module?

Encryption is Disabled

Are you using an external user-backend?

  • Default internal user-backend
  • LDAP/ Active Directory
  • SSO - SAML
  • Other

Nextcloud Server logs

No response

Additional info

No response

@PhilippSchlesinger PhilippSchlesinger changed the title [Bug]: [Bug]: ignored files always show state 'sync pending' Mar 14, 2023
@Plinsboorg
Copy link

I can confirm the same issue for me.

Software versions

I tested it on my personal PC: Windows 11 Home 22H2 build 22621.1413
And on the fresh Windows install in VM: Windows 10 Home 22H2 build 19045.2728
Nextcloud desktop client version 3.8.0
Nextcloud server. Tested on: 26.0.0, 25.0.2, 24.0.9
This issue shows up on both OS versions, and for each server version from above.

Ignored files and desktop.ini

You can see I added the .xyz file to the ignore list and it became permanently in pending sync state
ignored files are not synced
This issue also affects the desktop.ini files. Nextcloud ignores them as explained in this post (this post also confirms the issue). When you add a custom icon to the folder Windows creates desktop.ini inside of it. This file receives pending sync status and this status propagates to the folder itself and all folders above it.
When I remove the .xyz file from the ignore list it's synced just fine:

ignored files are not synced 2

But the issue with desktop.ini is not going anywhere.

Test with older version of file explorer

I also tested on the older version of Windows. Windows 10 Enterprise 1607. It had the older version of the file explorer that looks like this:
ignored files old file explorer
You can see the status icon is displayed close to the folder (not in the separate column). It is not syncing the desktop.ini files but they have a yellow icon instead of the blue (sync pending) icon. And this doesn't propagate to the folder above. You can see the Photos folder has a green icon despite the desctop.ini with a yellow icon inside of it. If you hide hidden files you will not see this in the old style of file explorer. That's why you didn't see this issue earlier.

Expected behavior

I would suggest different icon for the expected behavior.
image
I would expect the gray icon that is used by Onedrive. It also displays "Excluded from sync" message when you hover the mouse over this icon.

@Plinsboorg
Copy link

I found out that even on the new versions of Windows the status icons are displayed in the "old way" (near the folder icon) if you don't enable the virtual files support.
And without virtual files support enabled this issue is not observed.
image
Windows 11 Home 22H2
Nextcloud desktop client version 3.8.1
Virtual files support DISABLED

m7913d added a commit to m7913d/nc-desktop that referenced this issue Jul 2, 2023
Setting PinState to Excluded ensures the syncing icon is not shown for ignored items.
If the PinState is not set to Excluded, also all parent directories are shown as being synced, which is very inconvenient for the end user as it seems that some folder are never fully synced by Nextcloud which isn't the case.
As long as .lnk files are not converted to placeholder files, also set them to Excluded to hide the syncing icon.

Closes nextcloud#5524
Closes nextcloud#5594

Signed-off-by: Dries Mys <[email protected]>
m7913d added a commit to m7913d/nc-desktop that referenced this issue Jul 2, 2023
Setting PinState to Excluded ensures the syncing icon is not shown for ignored items.
If the PinState is not set to Excluded, also all parent directories are shown as being synced, which is very inconvenient for the end user as it seems that some folder are never fully synced by Nextcloud which isn't the case.
As long as .lnk files are not converted to placeholder files, also set them to Excluded to hide the syncing icon.

Closes nextcloud#5524
Closes nextcloud#5594

Signed-off-by: Dries Mys <[email protected]>
m7913d added a commit to m7913d/nc-desktop that referenced this issue Jul 2, 2023
Setting PinState to Excluded ensures the syncing icon is not shown for ignored items.
If the PinState is not set to Excluded, also all parent directories are shown as being synced, which is very inconvenient for the end user as it seems that some folder are never fully synced by Nextcloud which isn't the case.
As long as .lnk files are not converted to placeholder files, also set them to Excluded to hide the syncing icon.

Closes nextcloud#5524
Closes nextcloud#5594

Signed-off-by: Dries Mys <[email protected]>
m7913d added a commit to m7913d/nc-desktop that referenced this issue Jul 2, 2023
Setting PinState to Excluded ensures the syncing icon is not shown for ignored items.
If the PinState is not set to Excluded, also all parent directories are shown as being synced, which is very inconvenient for the end user as it seems that some folder are never fully synced by Nextcloud which isn't the case.
As long as .lnk files are not converted to placeholder files, also set them to Excluded to hide the syncing icon.

Closes nextcloud#5524
Closes nextcloud#5594

Signed-off-by: Dries Mys <[email protected]>
mgallien pushed a commit to m7913d/nc-desktop that referenced this issue Jul 7, 2023
Setting PinState to Excluded ensures the syncing icon is not shown for ignored items.
If the PinState is not set to Excluded, also all parent directories are shown as being synced, which is very inconvenient for the end user as it seems that some folder are never fully synced by Nextcloud which isn't the case.
As long as .lnk files are not converted to placeholder files, also set them to Excluded to hide the syncing icon.

Closes nextcloud#5524
Closes nextcloud#5594

Signed-off-by: Dries Mys <[email protected]>
mgallien pushed a commit to m7913d/nc-desktop that referenced this issue Jul 11, 2023
Setting PinState to Excluded ensures the syncing icon is not shown for ignored items.
If the PinState is not set to Excluded, also all parent directories are shown as being synced, which is very inconvenient for the end user as it seems that some folder are never fully synced by Nextcloud which isn't the case.
As long as .lnk files are not converted to placeholder files, also set them to Excluded to hide the syncing icon.

Closes nextcloud#5524
Closes nextcloud#5594

Signed-off-by: Dries Mys <[email protected]>
m7913d added a commit to m7913d/nc-desktop that referenced this issue Jul 14, 2023
Setting PinState to Excluded ensures the syncing icon is not shown for ignored items.
If the PinState is not set to Excluded, also all parent directories are shown as being synced, which is very inconvenient for the end user as it seems that some folder are never fully synced by Nextcloud which isn't the case.
As long as .lnk files are not converted to placeholder files, also set them to Excluded to hide the syncing icon.

Closes nextcloud#5524
Closes nextcloud#5594

Signed-off-by: Dries Mys <[email protected]>
mgallien pushed a commit to m7913d/nc-desktop that referenced this issue Jul 17, 2023
Setting PinState to Excluded ensures the syncing icon is not shown for ignored items.
If the PinState is not set to Excluded, also all parent directories are shown as being synced, which is very inconvenient for the end user as it seems that some folder are never fully synced by Nextcloud which isn't the case.
As long as .lnk files are not converted to placeholder files, also set them to Excluded to hide the syncing icon.

Closes nextcloud#5524
Closes nextcloud#5594

Signed-off-by: Dries Mys <[email protected]>
m7913d added a commit to m7913d/nc-desktop that referenced this issue Jul 17, 2023
Setting PinState to Excluded ensures the syncing icon is not shown for ignored items.
If the PinState is not set to Excluded, also all parent directories are shown as being synced, which is very inconvenient for the end user as it seems that some folder are never fully synced by Nextcloud which isn't the case.
As long as .lnk files are not converted to placeholder files, also set them to Excluded to hide the syncing icon.

Closes nextcloud#5524
Closes nextcloud#5594

Co-authored-by: Matthieu Gallien <[email protected]>
Signed-off-by: Dries Mys <[email protected]>
m7913d added a commit to m7913d/nc-desktop that referenced this issue Jul 18, 2023
Setting PinState to Excluded ensures the syncing icon is not shown for ignored items.
If the PinState is not set to Excluded, also all parent directories are shown as being synced, which is very inconvenient for the end user as it seems that some folder are never fully synced by Nextcloud which isn't the case.
As long as .lnk files are not converted to placeholder files, also set them to Excluded to hide the syncing icon.

Closes nextcloud#5524
Closes nextcloud#5594

Co-authored-by: Matthieu Gallien <[email protected]>
Signed-off-by: Dries Mys <[email protected]>
m7913d added a commit to m7913d/nc-desktop that referenced this issue Jul 19, 2023
Setting PinState to Excluded ensures the syncing icon is not shown for ignored items.
If the PinState is not set to Excluded, also all parent directories are shown as being synced, which is very inconvenient for the end user as it seems that some folder are never fully synced by Nextcloud which isn't the case.
As long as .lnk files are not converted to placeholder files, also set them to Excluded to hide the syncing icon.

Closes nextcloud#5524
Closes nextcloud#5594

Co-authored-by: Matthieu Gallien <[email protected]>
Signed-off-by: Dries Mys <[email protected]>
mgallien added a commit to m7913d/nc-desktop that referenced this issue Jul 20, 2023
Setting PinState to Excluded ensures the syncing icon is not shown for ignored items.
If the PinState is not set to Excluded, also all parent directories are shown as being synced, which is very inconvenient for the end user as it seems that some folder are never fully synced by Nextcloud which isn't the case.
As long as .lnk files are not converted to placeholder files, also set them to Excluded to hide the syncing icon.

Closes nextcloud#5524
Closes nextcloud#5594

Co-authored-by: Matthieu Gallien <[email protected]>
Signed-off-by: Dries Mys <[email protected]>
backportbot-nextcloud bot pushed a commit that referenced this issue Jul 20, 2023
Setting PinState to Excluded ensures the syncing icon is not shown for ignored items.
If the PinState is not set to Excluded, also all parent directories are shown as being synced, which is very inconvenient for the end user as it seems that some folder are never fully synced by Nextcloud which isn't the case.
As long as .lnk files are not converted to placeholder files, also set them to Excluded to hide the syncing icon.

Closes #5524
Closes #5594

Co-authored-by: Matthieu Gallien <[email protected]>
Signed-off-by: Dries Mys <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants