Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

windows reserved word silently excluded - csync exclude.cpp #4977

Merged
merged 3 commits into from
Jul 18, 2023
Merged

windows reserved word silently excluded - csync exclude.cpp #4977

merged 3 commits into from
Jul 18, 2023

Conversation

tomdereub
Copy link
Contributor

Proposal to solve #3826, by excluding silently windows reserved word like $RECYCLE.BIN.

Signed-off-by: tomdereub [email protected]

@mgallien
Copy link
Collaborator

@tomdereub can you look at the failing automated tests on excluded patterns and update them ?
thanks for your contribution

@come-nc come-nc requested a review from mgallien October 10, 2022 13:45
@come-nc
Copy link

come-nc commented Nov 22, 2022

/rebase

@tomdereub
Copy link
Contributor Author

@mgallien : is there still something that we can do for this PR or could it be merged ? It would be great to integrate it in next release.

@hunhejj
Copy link

hunhejj commented Jan 13, 2023

Any news here @mgallien ? The changeset looks legit IMO.

@mgallien
Copy link
Collaborator

mgallien commented Jul 7, 2023

@tomdereub
SonarCloud check would fail due to token being private
other checks should succeed before I can merge

@mgallien
Copy link
Collaborator

mgallien commented Jul 7, 2023

sorry for the delay
this was out of my list of TODO items

@tomdereub @mgallien
windows reserved word silently excluded - csync exclude.cpp
39e59a1 
Proposal to solve nextcloud#3826, by excluding silently windows reserved word like $RECYCLE.BIN.

Signed-off-by: tomdereub <[email protected]>
@tomdereub @mgallien
Adapt test to silent exclusion
d353f08 
Signed-off-by: tomdereub <[email protected]>
@tomdereub @mgallien
Adapt test 2
6aacf4d 
Signed-off-by: tomdereub <[email protected]>
@nextcloud-desktop-bot
Copy link

AppImage file: nextcloud-PR-4977-6aacf4ddac9aabb3c98c73b4372135db49f1ad91-x86_64.AppImage

To test this change/fix you can simply download above AppImage file and test it.

Please make sure to quit your existing Nextcloud app and backup your data.

@mgallien mgallien merged commit c6436c4 into nextcloud:master Jul 18, 2023
6 of 8 checks passed
@tomdereub
Copy link
Contributor Author

Thanks @mgallien ! Will it be integrated in next version of nextcloud desktop ? Bug is still present in 3.9.1.

@mgallien
Copy link
Collaborator

/backport to stable-3.9

@mgallien
Copy link
Collaborator

Thanks @mgallien ! Will it be integrated in next version of nextcloud desktop ? Bug is still present in 3.9.1.

that will be in the next one in about one month
@tomdereub I was not sure about backporting

@backportbot-nextcloud backportbot-nextcloud bot mentioned this pull request Jul 28, 2023
Merged
@allexzander allexzander added this to the 3.9.2 milestone Aug 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mgallien mgallien mgallien approved these changes

Assignees
No one assigned
Labels
backport-request
Projects
None yet
Milestone
3.9.2
Development

Successfully merging this pull request may close these issues.
6 participants
@tomdereub @mgallien @come-nc @hunhejj @nextcloud-desktop-bot @allexzander