Use 23.04 craft cache version as pixman is not (yet) available in 23.07 #5874
Conversation
KDE has recently switched the default craft cache version from 23.04 to 23.07 (see KDE/craft@a860e18). This new version does not include (yet?) the pixman libraries (see https://files.kde.org/craft/master/23.07/windows/cl/msvc2019/x86_64/RelWithDebInfo). Advantage of using a specific version is that new PR will not start to fail due to an (unexpected) upstream change. Signed-off-by: m7913d <[email protected]>
|
AppImage file: nextcloud-PR-5874-ba2ac850e7a4b4ad867b0880678b0eade46fbfe5-x86_64.AppImage |
|
The pixman library is now available in 23.07 too. Moreover, the pixman dependency is removed in commit nextcloud/desktop-client-blueprints@c9a496e. Either we should close this commit or we may set the Packager/CacheVersion to 23.07. Advantage of explicitly setting the cache version is that future upstream changes will not make (unrelated) PR to fail randomly. |
|
@m7913d I am not a fan of setting the version. In the past we did hardcode some version requirements in Craft to workaround temporary build failures. Then later the build fail because we did not follow up changes in upstream. as far as I can say, I would think that a cache refreshed via a scheduled action running maybe once a week and overriding existing cache only on success would isolate from temp failures without having to set versions in stone as I have no time to work on this, I am not asking you to do it for me 😄 |
|
Closing the PR as @mgallien prefers not setting a fixed version and 23.07 is now supported (see my previous comment). |
|
by the way, sorry |
KDE has recently switched the default craft cache version from 23.04 to 23.07 (see KDE/craft@a860e18). This new version does not include (yet?) the pixman libraries (see https://files.kde.org/craft/master/23.07/windows/cl/msvc2019/x86_64/RelWithDebInfo).
Advantage of using a specific version is that new PR will not start to fail due to an (unexpected) upstream change.
This PR fixes the failed "Windows Build and Test / Build" Github workflow.