Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

properly catch std::filesystem exceptions #7282

Merged
merged 1 commit into from
Oct 8, 2024

Conversation

mgallien
Copy link
Collaborator

@mgallien mgallien commented Oct 8, 2024

will prevent std::terminate from being called with uncatched exceptions

will prevent std::terminate from being called with uncatched exceptions

Signed-off-by: Matthieu Gallien <[email protected]>
@mgallien
Copy link
Collaborator Author

mgallien commented Oct 8, 2024

/backport to stable-3.14

@nextcloud-desktop-bot
Copy link

AppImage file: nextcloud-PR-7282-bac5a1d200f136a19cba8c88816ef86976d2311f-x86_64.AppImage

To test this change/fix you can simply download above AppImage file and test it.

Please make sure to quit your existing Nextcloud app and backup your data.

Copy link

sonarcloud bot commented Oct 8, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
C Maintainability Rating on New Code (required ≥ A)
19 New Code Smells (required ≤ 0)

See analysis details on SonarCloud

Catch issues before they fail your Quality Gate with our IDE extension SonarLint

@mgallien mgallien merged commit 0056a8c into master Oct 8, 2024
11 of 15 checks passed
@mgallien mgallien deleted the bugfix/catchFilesystemExceptions branch October 8, 2024 11:47
mgallien added a commit that referenced this pull request Oct 8, 2024
related to #7282

Signed-off-by: Matthieu Gallien <[email protected]>
mgallien added a commit that referenced this pull request Oct 8, 2024
related to #7282

Signed-off-by: Matthieu Gallien <[email protected]>
mgallien added a commit that referenced this pull request Oct 10, 2024
related to #7282

Signed-off-by: Matthieu Gallien <[email protected]>
mgallien added a commit that referenced this pull request Oct 17, 2024
related to #7282

Signed-off-by: Matthieu Gallien <[email protected]>
backportbot bot pushed a commit that referenced this pull request Oct 17, 2024
mgallien added a commit that referenced this pull request Oct 17, 2024
related to #7282

Signed-off-by: Matthieu Gallien <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants