Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bugfix/use file id to track renamed items #7334

Merged
merged 3 commits into from
Oct 17, 2024
Merged

Bugfix/use file id to track renamed items #7334

merged 3 commits into from
Oct 17, 2024

Commits on Oct 17, 2024

  1. in automated tests, update modtime when modifying the content of a file 

    why one would not update the modification time when modifying a remote
file during automated tests

there is no reason to not update the modification time as this is what
is done by the server

Signed-off-by: Matthieu Gallien <[email protected]>
    @mgallien
    mgallien committed Oct 17, 2024
    Configuration menu
    Copy the full SHA
    7301ad3 View commit details
    Browse the repository at this point in the history

  2. handle NEW/NEW conflicts by being real conflicts 

    NEW/NEW conflicts could sometime be ignored and replaced by update
metadata instructions

we stop doing this and handle them like any other conflicts

that would cause more download from the server

those conflicts would be solved automatically in case this is not a real
conflict but the client was missing the server reply with the updated
metadata

will enable more changes to improve MOVE detection from server side

Signed-off-by: Matthieu Gallien <[email protected]>
    @mgallien
    mgallien committed Oct 17, 2024
    Configuration menu
    Copy the full SHA
    f0908db View commit details
    Browse the repository at this point in the history

  3. remove the enforcement of identical etag for a server side item MOVE 

    orignally added by owncloud/client#6632

most probably a too strong assumption on the behavior of the Nextcloud
server

better check real item metadata like fileid, size or modification time

Signed-off-by: Matthieu Gallien <[email protected]>
    @mgallien
    mgallien committed Oct 17, 2024
    Configuration menu
    Copy the full SHA
    05b6db5 View commit details
    Browse the repository at this point in the history