Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix QML errors caused by illegal customisation of text field backgrounds on native styles #7374

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Fix QML errors caused by illegal customisation of text field backgrounds on native styles #7374

wants to merge 2 commits into from
+1 −11

Conversation

claucambra
Copy link
Collaborator

Fixes following errors:

2024-10-21 02:01:40:645 [ warning default qrc:/qml/src/gui/filedetails/ShareeSearchField.qml:53 ]:	qrc:/qml/src/gui/filedetails/ShareeSearchField.qml:53:17: QML QQuickRectangle: The current style does not support customization of this control (property: "background" item: QQuickRectangle(0x600001d42140, parent=0x0, geometry=0,0 0x0)). Please customize a non-native style (such as Basic, Fusion, Material, etc). For more information, see: https://doc.qt.io/qt-6/qtquickcontrols2-customize.html#customization-reference
2024-10-21 02:01:40:645 [ warning default qrc:/qml/src/gui/filedetails/NCInputTextField.qml:57 ]:	qrc:/qml/src/gui/filedetails/NCInputTextField.qml:57:17: QML QQuickRectangle: The current style does not support customization of this control (property: "background" item: QQuickRectangle(0x600001d42220, parent=0x0, geometry=0,0 0x0)). Please customize a non-native style (such as Basic, Fusion, Material, etc). For more information, see: https://doc.qt.io/qt-6/qtquickcontrols2-customize.html#customization-reference

@claucambra
Remove background from textfields to fix errors
3a49114 
Fixes the following errors:

ShareeSearchField.qml:53:17: QML QQuickRectangle: The current style does
not support customization of this control (property: "background" item:
QQuickRectangle(0x600001d42140, parent=0x0, geometry=0,0 0x0)).

NCInputTextField.qml:57:17: QML QQuickRectangle: The current style does
not support customization of this control (property: "background" item:
QQuickRectangle(0x600001d42220, parent=0x0, geometry=0,0 0x0)).

Signed-off-by: Claudio Cambra <[email protected]>
@claucambra
Add small top margin to shareview
3c983db 
Fixes highlight of sharee search field with macOS styling

Signed-off-by: Claudio Cambra <[email protected]>
@claucambra claucambra added this to the 3.14.3 milestone Oct 21, 2024
@claucambra claucambra self-assigned this Oct 21, 2024
@nextcloud-desktop-bot
Copy link

AppImage file: nextcloud-PR-7374-3c983db1a97b27d1d7c2e41b4ddab5a481874b28-x86_64.AppImage

To test this change/fix you can simply download above AppImage file and test it.

Please make sure to quit your existing Nextcloud app and backup your data.

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Oct 21, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@claucambra
Copy link
Collaborator Author

/backport to stable-3.14

@claucambra claucambra modified the milestones: 3.14.4, 3.14.5 Nov 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mgallien mgallien Awaiting requested review from mgallien

@camilasan camilasan Awaiting requested review from camilasan

At least 1 approving review is required to merge this pull request.

Assignees

@claucambra claucambra

Labels
backport-request
Projects
None yet
Milestone
3.14.5
Development

Successfully merging this pull request may close these issues.
2 participants
@claucambra @nextcloud-desktop-bot