-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
alpine php-fpm images #54
Conversation
@@ -0,0 +1,67 @@ | |||
FROM php:7.0-fpm-alpine |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should use the same php version as used by the other images, this would mean for nextcloud 9/10 php 5.6 and for nextcloud 11 php 7.1.
@@ -4,10 +4,13 @@ services: docker | |||
env: | |||
- VERSION=11.0 VARIANT=fpm | |||
- VERSION=11.0 VARIANT=apache | |||
- VERSION=11.0 VARIANT=alpine-fpm |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also you should use update.sh
to generate the Dockerfiles and update .travis.yml
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure. I've been working on this yesterday.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Agreed with @tilosp comments.
Thanks for your work, we are almost there!
&& git checkout php7 \ | ||
&& phpize \ | ||
&& ./configure \ | ||
&& make && make install \ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Isn't it possible to use pecl?
https://github.com/nextcloud/docker/blob/master/Dockerfile-php7.template#L38
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There were problems with php7 and Redis when I made the first version of the image but I'll try again. It would be cleaner.
Also, Memcache for php7 was broken then.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
in PHP7; is'nt it php-memcached instead of memcache ?
here it use alpine + php7 and memcached
https://github.com/linuxserver/docker-nextcloud/blob/master/Dockerfile
--with-freetype-dir=/usr/include/ \ | ||
--with-png-dir=/usr/include \ | ||
--with-jpeg-dir=/usr/include \ | ||
&& NPROC=$(getconf _NPROCESSORS_ONLN) \ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does it save a lot of time? I'd like to have images consistent and have the same logic.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No, of course. It's not important. I'll remove it.
&& apk del autoconf make g++ gcc git py-pip zlib-dev \ | ||
jpeg-dev libmcrypt-dev libpng-dev openldap-dev \ | ||
freetype-dev libjpeg-turbo-dev \ | ||
&& rm -rf /var/cache/apk/* |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would it be possible to have the same layers accross images? This would allow us to DRY things in the future.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes. I'll try to use the same layers for php 5.6.
Closed and reopened to manually trigger a Travis build |
Just adding this email we received:
|
To keep in mind before merging: #65 (comment) |
Closing this for now |
@pierreozoux please, check it :)
Cheers!