-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
📝 Include instructions on how to configure the server with Env Variables #9143
Conversation
This commit adds to the docs instructions on how to configure a Nextcloud instance to use Environment configuration when values aren't present in config.php. This should close nextcloud/docker#1544 and nextcloud/docker#1465 It should also render nextcloud/docker#1795 unnecessary. Signed-off-by: Leonardo Colman <[email protected]>
Please also document how this works with dicts and lists. |
Hi @Ornias1993 ! Absolutely! |
No idea. |
I'll do some exploring :D |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey 👋,
thanks for your pull request 👍
@PVince81 @CarlSchwan I have mixed feelings about adding this section to the documentation. Afaik we don't recommend this and it's not really done (for example lists are not supported or type conversions via env).
What would be the correct way to configure these variables using the environment? |
I'm afraid we don't have something else 🙈 Some examples: It does not work for It does not work for It may work for I'm okay with updating the documentation but then usually people start using a feature and some people might be confused when this way does not work for everything. A library like https://github.com/symfony/dotenv may help us to cover most of the cases. Let's see what Vincent and Carl think about your PR. |
I agree with you:
Having proper implementation is better, even better if we delegate it to somewhere else xD |
This commit adds to the docs instructions on how to configure a Nextcloud instance to use Environment configuration when values aren't present in config.php.
This should close nextcloud/docker#1544 and nextcloud/docker#1465
It should also render nextcloud/docker#1795 unnecessary.
Signed-off-by: Leonardo Colman [email protected]