Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix deprecated warning #1071

Merged
merged 1 commit into from
Jan 30, 2024
Merged

fix deprecated warning #1071

merged 1 commit into from
Jan 30, 2024

Conversation

brccabral
Copy link
Contributor

I was getting this warning when in Debug mode.

Creation of dynamic property OCA\FirstRunWizard\Settings\Personal::$urlGenerator is deprecated at /mnt/HDExtra/nextcloud-server/nextcloud/apps/firstrunwizard/lib/Settings/Personal.php#40

@szaimen szaimen requested a review from Pytal January 30, 2024 16:12
@szaimen szaimen added this to the Nextcloud 29 milestone Jan 30, 2024
Pytal
Pytal requested changes Jan 30, 2024
View reviewed changes
lib/Settings/Personal.php Outdated Show resolved Hide resolved
@Pytal
Copy link
Member

Pytal commented Jan 30, 2024

Please squash into one commit then we're good to go!

@brccabral @Pytal
fix deprecated warning
f29fdeb 
I was getting this warning when in Debug mode.
```
Creation of dynamic property OCA\FirstRunWizard\Settings\Personal::$urlGenerator is deprecated at /mnt/HDExtra/nextcloud-server/nextcloud/apps/firstrunwizard/lib/Settings/Personal.php#40
```

Signed-off-by: Bruno Cabral <[email protected]>

Update lib/Settings/Personal.php

The interface is already in the namespace

Co-authored-by: Pytal <[email protected]>
Signed-off-by: Bruno Cabral <[email protected]>
@Pytal Pytal enabled auto-merge January 30, 2024 21:55
@Pytal Pytal merged commit 87ff948 into nextcloud:master Jan 30, 2024
34 checks passed
@github-actions GitHub Actions
Copy link

Hello there,
Thank you so much for taking the time and effort to create a pull request to our Nextcloud project.

We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process.

Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6

Thank you for contributing to Nextcloud and we hope to hear from you soon!

@blizzz blizzz mentioned this pull request Mar 5, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Pytal Pytal Pytal approved these changes

Assignees
No one assigned
Labels
3. to review feedback-requested
Projects
None yet
Milestone
Nextcloud 29
Development

Successfully merging this pull request may close these issues.
3 participants
@brccabral @Pytal @szaimen