Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Adjust styles for Nextcloud 30 (default heading styles) #1184

Merged
merged 3 commits into from
Aug 6, 2024

Conversation

susnux
Copy link
Contributor

@susnux susnux commented Apr 22, 2024

@szaimen
Copy link
Collaborator

szaimen commented Apr 23, 2024

I am wondering, are the server styles not applied here? Because maintaining these styles in all places sounds very demanding to me...

@susnux
Copy link
Contributor Author

susnux commented Apr 23, 2024

They are, but we need to adjust, as our h3 here e.g. for cards would be too big.
they are fine if you use h2-h6 but we only have h2 and h3

@szaimen
Copy link
Collaborator

szaimen commented Apr 23, 2024

They are, but we need to adjust, as our h3 here e.g. for cards would be too big. they are fine if you use h2-h6 but we only have h2 and h3

I see. then lets do it like that

Copy link
Collaborator

@szaimen szaimen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just tested this and the headings still look a bit big?
image

@susnux
Copy link
Contributor Author

susnux commented Apr 23, 2024

Maybe we should also change the styles on server again to not use the h1 styles for h2 ... but just use h2 for h2 etc.
Because for non text documents a that big h2 makes no sense and we need to adjust the styles everywhere.

@szaimen
Copy link
Collaborator

szaimen commented Apr 23, 2024

Fyi @nextcloud/designers

Copy link

github-actions bot commented May 7, 2024

Hello there,
Thank you so much for taking the time and effort to create a pull request to our Nextcloud project.

We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process.

Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6

Thank you for contributing to Nextcloud and we hope to hear from you soon!

@Pytal
Copy link
Member

Pytal commented May 17, 2024

Should this get in @susnux?

@susnux
Copy link
Contributor Author

susnux commented Jun 17, 2024

Should this get in @susnux?

we need to do so, probably adjusting the size a bit more

@AndyScherzinger
Copy link
Member

@susnux if it is an improvement over the current state than I'd say let's merge as-is and have a follow-up. If it doesn't improve the situation in the current state of the PR, than let's leave it open for now.

@susnux
Copy link
Contributor Author

susnux commented Aug 6, 2024

@AndyScherzinger yes we need this otherwise it does not properly fit Nextcloud 30

@susnux
Copy link
Contributor Author

susnux commented Aug 6, 2024

/compile amend/

Signed-off-by: Ferdinand Thiessen <[email protected]>
Signed-off-by: nextcloud-command <[email protected]>
Copy link
Member

@Pytal Pytal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🐘

@AndyScherzinger AndyScherzinger merged commit ec39640 into master Aug 6, 2024
40 checks passed
@AndyScherzinger AndyScherzinger deleted the fix/nc30-styles branch August 6, 2024 17:21
@AndyScherzinger
Copy link
Member

Thanks @susnux - merged. I think daily pulls master-branch also for this app. Hence we can look at it tomorrow 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Font sizes are wrong after design changes
4 participants