Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix modal on mobile and a button #737

Merged
merged 1 commit into from
Sep 6, 2022
Merged

fix modal on mobile and a button #737

merged 1 commit into from
Sep 6, 2022

Conversation

szaimen
Copy link
Collaborator

@szaimen szaimen commented Sep 5, 2022

Close nextcloud/server#33828 and another issue with the button.

Before After
image image

Signed-off-by: szaimen [email protected]

@szaimen szaimen added this to the Nextcloud 25 milestone Sep 5, 2022
@szaimen szaimen marked this pull request as ready for review September 5, 2022 14:58
@szaimen szaimen changed the title fix modal on mobile fix modal on mobile and a button Sep 5, 2022
Copy link
Member

@jancborchardt jancborchardt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The mobile version looks good, but the icon in the "next" button seems too far to the left?

And for the desktop version, introducing a big dedicated space for the button looks a bit off. The overlap is fine, we just need to have nicer placing.
On tech-preview it looks like this, floating in the bottom right of the modal, which is actually great, and it scrolls so all fine. (Only weird thing is the logo is missing)
image

@szaimen
Copy link
Collaborator Author

szaimen commented Sep 6, 2022

The mobile version looks good, but the icon in the "next" button seems too far to the left?

And for the desktop version, introducing a big dedicated space for the button looks a bit off. The overlap is fine, we just need to have nicer placing. On tech-preview it looks like this, floating in the bottom right of the modal, which is actually great, and it scrolls so all fine. (Only weird thing is the logo is missing) image

Seems like my commit broke the button. Fixed it now.

@szaimen
Copy link
Collaborator Author

szaimen commented Sep 6, 2022

/compile amend /

Signed-off-by: szaimen <[email protected]>
Signed-off-by: nextcloud-command <[email protected]>
@szaimen szaimen merged commit d4d6163 into master Sep 6, 2022
@szaimen szaimen deleted the enh/33828/mobile-modal branch September 6, 2022 16:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[firstrunwizard] Design broken on mobile after design refresh
3 participants