Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[stable25] chore: update workflows from templates #933

Merged
merged 4 commits into from
Aug 15, 2023
Merged

[stable25] chore: update workflows from templates #933

merged 4 commits into from
Aug 15, 2023

Conversation

Pytal
Copy link
Member

@Pytal Pytal commented Jul 31, 2023

Backport #881

@Pytal Pytal added this to the Nextcloud 25.0.10 milestone Jul 31, 2023
@Pytal Pytal requested a review from szaimen July 31, 2023 18:12
@Pytal Pytal self-assigned this Jul 31, 2023
@blizzz blizzz mentioned this pull request Aug 2, 2023
Merged
@blizzz
Copy link
Member

blizzz commented Aug 3, 2023

moving to 25.0.11

@come-nc
Copy link
Contributor

come-nc commented Aug 3, 2023 

There were 2 errors:

1) OCA\FirstRunWizard\Tests\Controller\WizardControllerTest::testDisable with data set #0 ('test1')
explode(): Passing null to parameter #2 ($string) of type string is deprecated

/home/runner/work/firstrunwizard/firstrunwizard/apps/firstrunwizard/lib/Controller/WizardController.php:65
/home/runner/work/firstrunwizard/firstrunwizard/apps/firstrunwizard/tests/Controller/WizardControllerTest.php:64
/home/runner/work/firstrunwizard/firstrunwizard/apps/firstrunwizard/tests/Controller/WizardControllerTest.php:80

2) OCA\FirstRunWizard\Tests\Controller\WizardControllerTest::testDisable with data set #1 ('test2')
explode(): Passing null to parameter #2 ($string) of type string is deprecated

/home/runner/work/firstrunwizard/firstrunwizard/apps/firstrunwizard/lib/Controller/WizardController.php:65
/home/runner/work/firstrunwizard/firstrunwizard/apps/firstrunwizard/tests/Controller/WizardControllerTest.php:64
/home/runner/work/firstrunwizard/firstrunwizard/apps/firstrunwizard/tests/Controller/WizardControllerTest.php:80

Still failing, I’m moving on…

skjnldsv and others added 3 commits August 15, 2023 15:28
@skjnldsv @Pytal
chore: update workflows from templates
ff5f3de 
Signed-off-by: John Molakvoæ <[email protected]>
(cherry picked from commit a6c7072)
Signed-off-by: Christopher Ng <[email protected]>
@come-nc @Pytal
Update phpunit workflows to latest template
a5d4ea9 
Signed-off-by: Côme Chilliet <[email protected]>
@come-nc @Pytal
Do not fail phpunit on warnings
e5731a6 
Signed-off-by: Côme Chilliet <[email protected]>
Signed-off-by: Christopher Ng <[email protected]>
@Pytal Pytal force-pushed the backport/881/stable25 branch 2 times, most recently from 0138f76 to 764f4dc Compare August 15, 2023 22:52
@Pytal
fix(ci): phpunit deprecation error
b31fd7e 
- With PHP 8.1 passing null as the second param to explode() is deprecated

Signed-off-by: Christopher Ng <[email protected]>
@Pytal Pytal merged commit c5bc324 into stable25 Aug 15, 2023
23 checks passed
@Pytal Pytal deleted the backport/881/stable25 branch August 15, 2023 23:02
@blizzz blizzz mentioned this pull request Sep 5, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@szaimen szaimen Awaiting requested review from szaimen

Assignees

@Pytal Pytal

Labels
4. to release
Projects
None yet
Milestone
Nextcloud 25.0.11
Development

Successfully merging this pull request may close these issues.
4 participants
@Pytal @blizzz @come-nc @skjnldsv