Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Allow pasting log entries #1040

Merged
merged 3 commits into from
Feb 14, 2024
Merged

feat: Allow pasting log entries #1040

merged 3 commits into from
Feb 14, 2024

Conversation

susnux
Copy link
Contributor

@susnux susnux commented Nov 11, 2023

Before the Vue migration there was a hidden feature allowing you to paste on the logreader to show your clipboard content (log entries).
This is quite useful when e.g. having logs from GitHub issues.

So this PR brings back that function, to make it a bit more discoverable I added a info note to the settings modal:

image

And pasting looks like this, Firefox does not support Clipboard API so a fallback prompt is used:

vokoscreenNG-2023-11-11_01-07-11.mp4

Chromium / Chrome supports it, it just asks for confirmation / permissions and looks like this:

vokoscreenNG-2023-11-11_01-08-59.mp4

Copy link

codecov bot commented Nov 11, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (15fef4b) 100.00% compared to head (9f7887a) 44.42%.
Report is 3 commits behind head on master.

❗ Current head 9f7887a differs from pull request most recent head 7b7c0b7. Consider uploading reports for the commit 7b7c0b7 to get more accurate results

Additional details and impacted files
@@              Coverage Diff               @@
##              master    #1040       +/-   ##
==============================================
- Coverage     100.00%   44.42%   -55.58%     
- Complexity         0      168      +168     
==============================================
  Files             10       26       +16     
  Lines            168      700      +532     
  Branches          31       33        +2     
==============================================
+ Hits             168      311      +143     
- Misses             0      389      +389     
Flag Coverage Δ
unit 25.19% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@susnux susnux force-pushed the fix/ui-vue-8 branch 4 times, most recently from d4abf37 to 9f7887a Compare November 11, 2023 18:58
@blizzz blizzz added this to the Nextcloud 29 milestone Nov 23, 2023
Copy link

Hello there,
Thank you so much for taking the time and effort to create a pull request to our Nextcloud project.

We hope that the reviewing process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR reviewing process.

Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6

Thank you for contributing to Nextcloud and we hope to hear from you soon!

@szaimen
Copy link

szaimen commented Nov 30, 2023

Just tested and seems like I found two bugs?
image
image

@susnux
Copy link
Contributor Author

susnux commented Dec 13, 2023

@szaimen what do you mean with bugs? Or better: What did you do to end up with that state?

@szaimen
Copy link

szaimen commented Jan 2, 2024

@szaimen what do you mean with bugs? Or better: What did you do to end up with that state?

I ended up in this state when I was testing the PR with my easy test instance which logs the log to stdout by default. If you now upload a log file or paste from clipboard, you can see the screenshots.

@icewind1991
Copy link
Member

icewind1991 commented Jan 4, 2024

instead of using keyboard events, you can use the paste event which will give you the text on all (afaik) browsers without prompt.

Signed-off-by: Ferdinand Thiessen <[email protected]>
@icewind1991
Copy link
Member

switched to the paste event

@icewind1991 icewind1991 merged commit 5b52869 into master Feb 14, 2024
24 checks passed
@icewind1991 icewind1991 deleted the fix/ui-vue-8 branch February 14, 2024 14:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants