Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix favicon caching on invalid paths #1018

Merged
merged 1 commit into from
Aug 8, 2018
Merged

Fix favicon caching on invalid paths #1018

merged 1 commit into from
Aug 8, 2018

Conversation

ChristophWurst
Copy link
Member

@ChristophWurst ChristophWurst commented Aug 8, 2018 •
edited
Loading

This prevents the lib from writing cache files to the vendor dir.

Ref https://sentry.rullzer.com/share/issue/b64f0d016338469f8b059ddc2f4a6e4a/.

@ChristophWurst ChristophWurst added this to the 0.10.0 milestone Aug 8, 2018
@ChristophWurst ChristophWurst self-assigned this Aug 8, 2018
@ChristophWurst
Copy link
Member Author

This prevents the lib from writing cache files to the vendor dir.

https://github.com/ArthurHoaro/favicon/blob/02163a16798bb024b0a413aa38400226665c1b2a/src/Favicon/Favicon.php#L316-L320

@ChristophWurst ChristophWurst modified the milestones: 0.10.0, 0.9.0 Aug 8, 2018
@ChristophWurst ChristophWurst merged commit 0a152b7 into master Aug 8, 2018
@ChristophWurst ChristophWurst deleted the fix/favicon-lib-caching branch August 8, 2018 12:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rullzer rullzer rullzer approved these changes

Assignees

@ChristophWurst ChristophWurst

Labels
3. to review bug
Projects
None yet
Milestone
0.9.0
Development

Successfully merging this pull request may close these issues.
2 participants
@ChristophWurst @rullzer