Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix duplicate files / case-sensitivity issues #1171

Merged
merged 1 commit into from
Sep 28, 2018

Conversation

kevgathuku
Copy link
Contributor

@kevgathuku kevgathuku commented Sep 27, 2018

On a case-insensitive filesystem e.g. on MacOS, I'm having some issues with files that have the same name but the name is in different cases and different content.
e.g. in the attached image, you can see that we have 2 files named accountservice.js and AccountService.js
Same for FolderService.js and MessageService.js

My filesystem is treating those 2 as the same file and git is having issues differentiating the files.

The PR addresses this issue by removing the old files i.e.

  • accountservice.js
  • folderservice.js
  • messageservice.js

screen shot 2018-09-27 at 19 24 03

@kevgathuku
Copy link
Contributor Author

kevgathuku commented Sep 27, 2018

This is a blocker for me. Due to the git confusion I can't do much in git right now
e.g. switching branches

Copy link
Member

@ChristophWurst ChristophWurst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Whoops, sorry.

Thanks for fixing this!

Fun fact: a few days ago I even thought to myself: "how do case-insensitive OSes handle these files?" 🙈

@ChristophWurst ChristophWurst merged commit 03f9a51 into refactor/vue Sep 28, 2018
@ChristophWurst ChristophWurst deleted the fix/case-sensitivity branch September 28, 2018 05:06
@kevgathuku kevgathuku mentioned this pull request Sep 29, 2018
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants