fix(nextcloud)!: Require content-length for all WebDAV put requests #1987
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: provokateurin <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1987 +/- ##
=======================================
Coverage 28.85% 28.85%
=======================================
Files 249 249
Lines 84111 84111
=======================================
Hits 24269 24269
Misses 59842 59842
*This pull request uses carry forward flags. Click here to find out more.
|
Leptopoda
reviewed
Apr 28, 2024
| @@ -146,23 +146,23 @@ class WebDavClient { | |||
| /// * [putStream] for a complete operation executing this request. | |||
| http.BaseRequest putStream_Request( | |||
| Stream<List<int>> localData, | |||
| int contentLength, | |||
There was a problem hiding this comment.
I'd like to leave this as a named parameter.
- easier to read code
- less breaking for our users
|
I don't like having a breaking release because this doesn't fix anything that is actually broken. Maybe it makes more sense to add an assert or print a log to inform the developers they are probably making a mistake? I'm not sure what the best way is... I'd also be open to not merge this patch at all and just add some doc comments that explain why it is important to set the parameter 🤷♀️ |
|
I'm fine with either way. |
provokateurin
deleted the
fix/nextcloud/webdav-put-require-content-length
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some specific setups do not like it when the content-length header is not present. The consumer of the package should always know the size of the data they are trying to upload, so enforcing the content-length is no problem.
For reference: saber-notes/saber#945 saber-notes/saber#1232