-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(dynamite)!: add Built
interface to the generated interfaces
#2000
feat(dynamite)!: add Built
interface to the generated interfaces
#2000
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
2000 🎉
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2000 +/- ##
==========================================
- Coverage 30.66% 28.92% -1.74%
==========================================
Files 259 250 -9
Lines 84891 84371 -520
==========================================
- Hits 26032 24408 -1624
- Misses 58859 59963 +1104
*This pull request uses carry forward flags. Click here to find out more.
|
@Leptopoda I think this commit shouldn't be marked as breaking and we can merge it right away because you only add new methods and don't remove or change existing ones. |
it shouldn't be breaking but what if a consumer was implementing our interface? Maybe we should mark them as final. |
Yep, nobody should implement these interfaces... |
We can only make our built class final. Doing the same to our interfaces would break our mocks. |
After #2190 this is no longer a breaking change as really nobody else can implement the interface now. |
Signed-off-by: Nikolas Rimikis <[email protected]>
a168391
to
a83cd27
Compare
Allows calling
toBuilder
andrebuild
on the interface making it a drop in replacement to the built class itself.related to #1995
As this is not needed yet I'd like to wait until other breaking changes accumulate.