Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(neon_framework): Migrate to notifications_push_repository #2528

Merged

Conversation

provokateurin
Copy link
Member

Fixes #577

Tests still to be written

Copy link

codecov bot commented Sep 29, 2024

Codecov Report

Attention: Patch coverage is 78.00000% with 11 lines in your changes missing coverage. Please review.

Project coverage is 28.79%. Comparing base (c52acef) to head (a01e746).
Report is 3 commits behind head on main.

Files with missing lines Patch % Lines
...ackages/neon_framework/lib/src/pages/settings.dart 0.00% 6 Missing ⚠️
...ckages/neon_framework/lib/src/blocs/next_push.dart 0.00% 3 Missing ⚠️
...es/neon_framework/lib/src/utils/global_popups.dart 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2528      +/-   ##
==========================================
+ Coverage   28.67%   28.79%   +0.11%     
==========================================
  Files         366      370       +4     
  Lines      136299   136490     +191     
==========================================
+ Hits        39079    39296     +217     
+ Misses      97220    97194      -26     
Flag Coverage Δ *Carryforward flag
account_repository 98.47% <ø> (ø)
cookie_store 99.48% <ø> (ø) Carriedforward from c52acef
dashboard_app 96.05% <ø> (ø)
dynamite 31.05% <ø> (ø) Carriedforward from c52acef
dynamite_end_to_end_test 61.69% <ø> (ø) Carriedforward from c52acef
dynamite_runtime 85.40% <ø> (ø) Carriedforward from c52acef
interceptor_http_client 97.18% <ø> (ø) Carriedforward from c52acef
neon_dashboard 96.05% <ø> (ø) Carriedforward from c52acef
neon_framework 61.00% <78.00%> (+1.79%) ⬆️
neon_http_client 97.50% <ø> (ø) Carriedforward from c52acef
neon_notifications 100.00% <ø> (ø) Carriedforward from c52acef
neon_storage 94.66% <ø> (ø) Carriedforward from c52acef
neon_talk 99.45% <ø> (ø) Carriedforward from c52acef
nextcloud 24.26% <ø> (ø) Carriedforward from c52acef
notifications_app 97.40% <ø> (ø) Carriedforward from c52acef
notifications_push_repository 98.11% <ø> (-0.49%) ⬇️
sort_box 90.90% <ø> (ø) Carriedforward from c52acef
talk_app 98.94% <ø> (ø)

*This pull request uses carry forward flags. Click here to find out more.

Files with missing lines Coverage Δ
...on_framework/lib/src/blocs/push_notifications.dart 100.00% <100.00%> (ø)
...s/neon_framework/lib/src/utils/global_options.dart 0.00% <ø> (ø)
...kages/neon_framework/lib/src/utils/push_utils.dart 97.02% <100.00%> (ø)
...ository/lib/src/notifications_push_repository.dart 98.88% <ø> (ø)
...es/neon_framework/lib/src/utils/global_popups.dart 0.00% <0.00%> (ø)
...ckages/neon_framework/lib/src/blocs/next_push.dart 0.00% <0.00%> (ø)
...ackages/neon_framework/lib/src/pages/settings.dart 0.00% <0.00%> (ø)

... and 4 files with indirect coverage changes

@Leptopoda
Copy link
Member

So far LGTM
Can't wait for the tests :)

@provokateurin provokateurin force-pushed the fix/neon_framework/migrate-notifications_push_repository branch from ffb6bbf to f13a18c Compare October 8, 2024 19:28
@provokateurin
Copy link
Member Author

@Leptopoda ready with tests :)
There are some more things I want to fix regarding push notifications, but I would like to do those as follow-ups to at least have working push notifications again.

@provokateurin provokateurin force-pushed the fix/neon_framework/migrate-notifications_push_repository branch from f13a18c to a01e746 Compare October 19, 2024 12:21
@provokateurin provokateurin merged commit e9b9abb into main Oct 19, 2024
10 checks passed
@provokateurin provokateurin deleted the fix/neon_framework/migrate-notifications_push_repository branch October 19, 2024 12:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Refactor push notification registration
2 participants