Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix missing browser notifications #1289

Merged
merged 2 commits into from
Sep 26, 2022

Conversation

nickvergessen
Copy link
Member

@nickvergessen nickvergessen commented Sep 26, 2022

See code above the diff:

		// Parents: TransitionGroup > Transition > HeaderMenu
		if (typeof this.$parent.$parent.$parent.showBrowserNotifications === 'undefined') {
			console.error('Failed to read showBrowserNotifications property from App component')
		}

we made use the prop exists, but the check had a parent more than the usage afterwards.

Signed-off-by: Joas Schilling <[email protected]>
@nickvergessen
Copy link
Member Author

/backport fc2fe2f to stable25

@artonge artonge merged commit 3f84e6d into master Sep 26, 2022
@artonge artonge deleted the bugfix/noid/fix-missing-browser-notifications branch September 26, 2022 14:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants