Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add sidebar button on the Navigation #11

Merged
merged 2 commits into from
Dec 5, 2019
Merged

Add sidebar button on the Navigation #11

merged 2 commits into from
Dec 5, 2019

Conversation

jakobroehrl
Copy link
Contributor

@jakobroehrl jakobroehrl commented Nov 28, 2019

Signed-off-by: Jakob [email protected]
fix #9

This is not working:
OCA.Files.Sidebar.open(this.filename)
Error in v-on handler: "TypeError: Cannot read property 'Sidebar' of undefined"

@jakobroehrl jakobroehrl changed the title add icon Add sidebar button on the Navigation Nov 29, 2019
@jakobroehrl
Copy link
Contributor Author

@skjnldsv Could you look over this, please?

@skjnldsv skjnldsv added 2. developing Work in progress enhancement New feature or request labels Dec 2, 2019
@skjnldsv
Copy link
Member

skjnldsv commented Dec 3, 2019

It will need nextcloud/server#18213
please help the review @jakobroehrl :)

@jakobroehrl
Copy link
Contributor Author

Pulled 18213 into server
But it's not working for me: TypeError: Cannot read property 'Sidebar' of undefined
On the photo repo I had to add your changes manually. Git pull doesn't pull it.

@skjnldsv
Copy link
Member

skjnldsv commented Dec 4, 2019

Git pull doesn't pull it.

what is your issue?

Cannot read property 'Sidebar' of undefined

AH yes server is not compiled, let me fix

@jakobroehrl
Copy link
Contributor Author

Git pull doesn't pull it.
what is your issue?

How can I get your changes on this branch? Git pull says there are no tracking informations.

But If I add your code manually, now it's working: The sidebar shows up, with infinitely loading
grafik

@skjnldsv
Copy link
Member

skjnldsv commented Dec 4, 2019

But If I add your code manually, now it's working: The sidebar shows up, with infinitely loading

probably an issue in the console?
Could you paste it here?

@jakobroehrl
Copy link
Contributor Author

probably an issue in the console?
Could you paste it here?

Sure: TypeError: OCA.Files.App.fileList._getIconUrl is not a function

@skjnldsv
Copy link
Member

skjnldsv commented Dec 4, 2019

Sure: TypeError: OCA.Files.App.fileList._getIconUrl is not a function

Should be fixed on server

@jakobroehrl
Copy link
Contributor Author

It's working now :)
grafik

@skjnldsv
Copy link
Member

skjnldsv commented Dec 4, 2019

It's working now :)

you don't have the sharing content?
That's weird

@jakobroehrl
Copy link
Contributor Author

you don't have the sharing content?
That's weird

Now it's working even with sharing. :)

grafik

Signed-off-by: Jakob <[email protected]>
@skjnldsv
Copy link
Member

skjnldsv commented Dec 5, 2019

ALl done, @jakobroehrl please review ;)

@skjnldsv skjnldsv added 3. to review Waiting for reviews and removed 2. developing Work in progress labels Dec 5, 2019
@skjnldsv
Copy link
Member

skjnldsv commented Dec 5, 2019

/compile amend /

Signed-off-by: John Molakvoæ (skjnldsv) <[email protected]>
Signed-off-by: npmbuildbot[bot] <npmbuildbot[bot]@users.noreply.github.com>
@skjnldsv skjnldsv merged commit b08ead7 into master Dec 5, 2019
@skjnldsv skjnldsv deleted the sharingSidebar branch December 5, 2019 16:28
@skjnldsv skjnldsv added this to the 1.0.0 milestone Dec 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add sidebar button on the Navigation
2 participants