Copy how cypress is run on the server #1622
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
artonge
force-pushed
the
artonge/e2e/match_cypress_config_with_server
branch
from
4964377
to
1386f76
Compare
skjnldsv
reviewed
Feb 1, 2023
Signed-off-by: Louis Chemineau <[email protected]>
artonge
force-pushed
the
artonge/e2e/match_cypress_config_with_server
branch
from
1386f76
to
e66d96d
Compare
skjnldsv
reviewed
Feb 1, 2023
Comment on lines
+108
to
+110
| selectMedia([1, 2]) | ||
| downloadSelection() | ||
| unselectMedia([1, 2]) |
There was a problem hiding this comment.
Any reason not to make those cypress commands?
There was a problem hiding this comment.
Mostly typings. Is there a reason to make them cypress commands ? I thought commands were the way to go, but it does not add anything in my experience.
artonge
requested review from
skjnldsv,
marcelklehr,
a team,
Pytal and
szaimen
and removed request for
a team
|
Sorry but I could onky give a 🐘 on this |
marcelklehr
reviewed
Feb 8, 2023
|
/backport to stable25 |
backportbot-nextcloud
bot
added
the
backport-request
|
The backport to stable25 failed. Please do this backport manually. # Switch to the target branch and update it
git checkout stable25
git pull origin stable25
# Create the new backport branch
git checkout -b fix/foo-stable25
# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts. Resolve them.
git cherry-pick abc123
# Push the cherry pick commit to the remote repository and open a pull request
git push origin fix/foo-stable25More info at https://docs.nextcloud.com/server/latest/developer_manual/getting_started/development_process.html#manual-backport |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This make e2e experience nicer and the code cleaner
This also takes advantages of sessions, so tests should run faster. Confirmed, tests ran in 3:48 min, where average for this repo was 6:04 min