Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adapt focus-visible styles for checkboxes on images #2196

Merged
merged 1 commit into from
Dec 19, 2023

Conversation

JuliaKirschenheuter
Copy link
Contributor

Fixes #2160

Follow-up for #2182

Before:

Contrast difference between focused and unfocused state is under 3:1:

Peek 2023-12-15 16-28

Peek 2023-12-15 16-27

After:

Dark theme:

Peek 2023-12-15 16-04

Light theme:

Peek 2023-12-15 16-00

Copy link
Contributor

@emoral435 emoral435 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! just squash the commits together and its good :)

Copy link
Member

@nimishavijay nimishavijay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good in the screenshots! :)

@JuliaKirschenheuter
Copy link
Contributor Author

/backport to stable28

@backportbot-nextcloud backportbot-nextcloud bot added the backport-request Pending backport by the backport-bot label Dec 18, 2023
@JuliaKirschenheuter JuliaKirschenheuter force-pushed the fix/2160-create_accessible_ckeckboxes_for_media branch from 28be024 to 4d77706 Compare December 18, 2023 15:58
@JuliaKirschenheuter
Copy link
Contributor Author

/compile amend /

Signed-off-by: julia.kirschenheuter <[email protected]>
Signed-off-by: nextcloud-command <[email protected]>
@nextcloud-command nextcloud-command force-pushed the fix/2160-create_accessible_ckeckboxes_for_media branch from 4d77706 to 062819c Compare December 19, 2023 10:21
@emoral435 emoral435 merged commit 82fdcf4 into master Dec 19, 2023
23 checks passed
@emoral435 emoral435 deleted the fix/2160-create_accessible_ckeckboxes_for_media branch December 19, 2023 10:33
@backportbot-nextcloud
Copy link

The backport to stable28 failed. Please do this backport manually.

# Switch to the target branch and update it
git checkout stable28
git pull origin stable28

# Create the new backport branch
git checkout -b fix/foo-stable28

# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts. Resolve them.
git cherry-pick abc123

# Push the cherry pick commit to the remote repository and open a pull request
git push origin fix/foo-stable28

Error: Unknown error

More info at https://docs.nextcloud.com/server/latest/developer_manual/getting_started/development_process.html#manual-backport

Copy link
Contributor

Hello there,
Thank you so much for taking the time and effort to create a pull request to our Nextcloud project.

We hope that the reviewing process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR reviewing process.

Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6

Thank you for contributing to Nextcloud and we hope to hear from you soon!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews backport-request Pending backport by the backport-bot feedback-requested
Projects
None yet
4 participants