Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: glitch buttons on mobile #2212

Merged
merged 2 commits into from
Dec 22, 2023
Merged

Conversation

ShGKme
Copy link
Contributor

@ShGKme ShGKme commented Dec 22, 2023

Buggy reaction on slot default content update in Vue 2.

Without #default there is always a default slot with probably empty content, that is always passed as a content. With template v-if it is passed as a render function and not passed at all when there is no content to be set.

Before After
photos-glitch-before photos-glitch-after

@ShGKme ShGKme added bug Something isn't working 3. to review Waiting for reviews labels Dec 22, 2023
@ShGKme ShGKme self-assigned this Dec 22, 2023
@ShGKme
Copy link
Contributor Author

ShGKme commented Dec 22, 2023

/backport 7eb0f56 to stable28

@backportbot-nextcloud backportbot-nextcloud bot added the backport-request Pending backport by the backport-bot label Dec 22, 2023
@ShGKme
Copy link
Contributor Author

ShGKme commented Dec 22, 2023

I cannot understand why my local build doesn't work for Photos CI 🙈

@ShGKme ShGKme added this to the Nextcloud 29 milestone Dec 22, 2023
@ShGKme
Copy link
Contributor Author

ShGKme commented Dec 22, 2023

/compile amend /

Signed-off-by: Grigorii K. Shartsev <[email protected]>
Signed-off-by: nextcloud-command <[email protected]>
Copy link
Contributor

@JuliaKirschenheuter JuliaKirschenheuter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@JuliaKirschenheuter JuliaKirschenheuter merged commit 7608ef2 into master Dec 22, 2023
23 checks passed
@JuliaKirschenheuter JuliaKirschenheuter deleted the fix/glitch-buttons-on-mobile branch December 22, 2023 16:00
@backportbot-nextcloud backportbot-nextcloud bot removed the backport-request Pending backport by the backport-bot label Dec 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews bug Something isn't working
Projects
None yet
2 participants