Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

also fix additional place regarding album modal header #2262

Merged
merged 2 commits into from
Jan 19, 2024

Conversation

szaimen
Copy link
Contributor

@szaimen szaimen commented Jan 19, 2024

Fix #2258

Before After
image image

@szaimen szaimen added design Related to the design 2. developing Work in progress accessibility labels Jan 19, 2024
@szaimen szaimen added this to the Nextcloud 29 milestone Jan 19, 2024
@szaimen szaimen marked this pull request as ready for review January 19, 2024 11:40
@szaimen szaimen added 3. to review Waiting for reviews and removed 2. developing Work in progress labels Jan 19, 2024
@szaimen
Copy link
Contributor Author

szaimen commented Jan 19, 2024

/compile

@szaimen
Copy link
Contributor Author

szaimen commented Jan 19, 2024

/backport 2bc7735 to stable28

@backportbot backportbot bot added the backport-request Pending backport by the backport-bot label Jan 19, 2024
Signed-off-by: nextcloud-command <[email protected]>
Copy link
Contributor

@ShGKme ShGKme left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd still vote for migration to NcDialog. For example, NcDialog labels a dialog by this visible header.

@szaimen szaimen merged commit 003726b into master Jan 19, 2024
24 checks passed
@szaimen szaimen deleted the enh/2258/fix-modal branch January 19, 2024 13:18
@backportbot backportbot bot removed the backport-request Pending backport by the backport-bot label Jan 19, 2024
@JuliaKirschenheuter
Copy link
Contributor

Great, thank you @szaimen ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews accessibility design Related to the design
Projects
None yet
Development

Successfully merging this pull request may close these issues.

New albums picker in albums broken
4 participants