Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(migrations): duplicated preference #2571

Merged
merged 1 commit into from
Aug 6, 2024

Conversation

Altahrim
Copy link
Collaborator

@Altahrim Altahrim commented Aug 2, 2024

Fix #2570

@Altahrim Altahrim added the 3. to review Waiting for reviews label Aug 2, 2024
@Altahrim Altahrim added this to the Nextcloud 30 milestone Aug 2, 2024
@Altahrim Altahrim self-assigned this Aug 2, 2024
Copy link
Member

@nickvergessen nickvergessen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good and should fix the issue

lib/Migration/Version30000Date20240417075404.php Outdated Show resolved Hide resolved
Copy link
Member

@nickvergessen nickvergessen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing version bump in info.xml to execute the migration on deployment

@Altahrim Altahrim force-pushed the fix/duplicate-entry-migration branch from f98229d to 699c2e0 Compare August 2, 2024 13:04
@Altahrim Altahrim marked this pull request as ready for review August 2, 2024 13:08
@Altahrim Altahrim added the bug Something isn't working label Aug 2, 2024
@skjnldsv skjnldsv removed their request for review August 2, 2024 13:37
@Altahrim Altahrim force-pushed the fix/duplicate-entry-migration branch from 699c2e0 to e027ce1 Compare August 2, 2024 13:53
@Altahrim Altahrim enabled auto-merge August 2, 2024 13:53
Signed-off-by: Benjamin Gaussorgues <[email protected]>
@Altahrim Altahrim force-pushed the fix/duplicate-entry-migration branch from e027ce1 to 22a71db Compare August 5, 2024 09:30
@Altahrim Altahrim merged commit 65dec48 into master Aug 6, 2024
44 checks passed
@Altahrim Altahrim deleted the fix/duplicate-entry-migration branch August 6, 2024 08:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Integrity constraint violation for PRIMARY with migration Version3000Date20240417075404
4 participants