fix: pollId equals 0

[hamza221]

fix #3649

[dartcafe]

Your approach aborts the watch, but it should still run, if no poll is loaded.

Instead the watch at the server side should just avoid the the db request and continue watching other poll`s changes to keep the polls list up to date.

The watch is meant to watch changes in the current poll and the polls list.

[dartcafe]

A better approach would be to simply skip searching for a poll, if the id is 0 here:

polls/lib/Service/WatchService.php

Lines 38 to 41 in 32d0410

	public function watchUpdates(int $pollId, ?int $offset = null): array {
	$this->pollMapper->find($pollId)->request(Poll::PERMISSION_POLL_VIEW);
	$start = time();

[dartcafe]

Ay. This will also result in an interruption of the watcher. If no pollId (aka 0) is given, the watcher should just not search for a poll, but still keep watching for changes.

I meant skipping the line 44 in case of no pollId given.

The job for the watcher is to wait for updates of the polls table and then return the changes back to the client to enable the client for real time updates.

Additionally, if a pollId is given, it deep watches for changes of the particular poll also (Votes, Option, comments, etc.).