Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check for mimetypes and files app before trying to navigate #292

Merged
merged 2 commits into from
Sep 10, 2020

Conversation

juliushaertl
Copy link
Member

@juliushaertl juliushaertl commented Sep 10, 2020

Requires nextcloud/viewer#605

Fixes #291

Otherwise opening files that are not supported by viewer will just fail instead of navigating to the files app.

@skjnldsv
Copy link
Member

Ideally this would be a job for the new fileactions api, once-we-have-it™

@juliushaertl juliushaertl merged commit a624aee into master Sep 10, 2020
@juliushaertl juliushaertl deleted the bugfix/noid/mimetype-check branch September 10, 2020 13:04
@rullzer rullzer mentioned this pull request Sep 10, 2020
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Click on a folder/unsupported file tries to open the viewer
3 participants