Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add rector #4045

Merged
merged 3 commits into from
Sep 19, 2024
Merged

Add rector #4045

merged 3 commits into from
Sep 19, 2024

Conversation

juliushaertl
Copy link
Member

@juliushaertl juliushaertl commented Sep 18, 2024

Add rector and apply automatic fixes :)

Signed-off-by: Julius Knorr <[email protected]>
Signed-off-by: Julius Knorr <[email protected]>
@juliushaertl juliushaertl changed the title chore/rector Add rector Sep 18, 2024
Copy link
Member

@blizzz blizzz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nitpicking on some constructor parameter lists

lib/Backgroundjobs/Cleanup.php Outdated Show resolved Hide resolved
lib/Controller/DocumentAPIController.php Outdated Show resolved Hide resolved
lib/Db/AssetMapper.php Outdated Show resolved Hide resolved
lib/Events/DocumentOpenedEvent.php Outdated Show resolved Hide resolved
lib/Listener/BeforeFetchPreviewListener.php Outdated Show resolved Hide resolved
lib/Listener/LoadViewerListener.php Outdated Show resolved Hide resolved
lib/Listener/ShareLinkListener.php Outdated Show resolved Hide resolved
lib/Service/DemoService.php Outdated Show resolved Hide resolved
lib/Service/FederationService.php Outdated Show resolved Hide resolved
lib/Settings/Section.php Outdated Show resolved Hide resolved
@juliushaertl juliushaertl merged commit 3c140fa into main Sep 19, 2024
68 of 71 checks passed
@juliushaertl juliushaertl deleted the chore/rector branch September 19, 2024 11:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Ready to be reviewed technical debt
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants