feat: Use file cache query builder for searching for favorites

Signed-off-by: Julius Härtl <[email protected]>

apps/dav/lib/Connector/Sabre/FilesReportPlugin.php

@@ -33,6 +33,7 @@
 use OCP\Files\Node as INode;
 use OCP\IGroupManager;
 use OCP\ITagManager;
+use OCP\ITags;
 use OCP\IUserSession;
 use OCP\SystemTag\ISystemTagManager;
 use OCP\SystemTag\ISystemTagObjectMapper;
@@ -363,6 +364,33 @@ protected function processFilterRulesForFileNodes(array $filterRules, ?int $limi
 			}
 		}
 
+		$ns = '{' . $this::NS_OWNCLOUD . '}';
+		$favoriteFilter = null;
+		foreach ($filterRules as $filterRule) {
+			if ($filterRule['name'] === $ns . 'favorite') {
+				$favoriteFilter = true;
+			}
+		}
+
+		if ($favoriteFilter !== null) {
+			$tmpNodes = $this->userFolder->searchByTag(ITags::TAG_FAVORITE, $this->userSession->getUser()->getUID());
+			if (count($nodes) === 0) {
+				$nodes = $tmpNodes;
+			} else {
+				$nodes = array_uintersect($nodes, $tmpNodes, function (INode $a, INode $b): int {
+					return $a->getId() - $b->getId();
+				});
+			}
+			if ($nodes === []) {
+				// there cannot be a common match when nodes are empty early.
+				return $nodes;
+			}
+
+			if ($limit !== null || $offset !== null) {
+				$nodes = array_slice($nodes, $offset, $limit);
+			}
+		}
+
 		return $nodes;
 	}
 

lib/private/Files/Node/Folder.php

@@ -295,8 +295,8 @@ public function searchByMime($mimetype) {
 	 * @param string $userId owner of the tags
 	 * @return Node[]
 	 */
-	public function searchByTag($tag, $userId) {
-		$query = $this->queryFromOperator(new SearchComparison(ISearchComparison::COMPARE_EQUAL, 'tagname', $tag), $userId);
+	public function searchByTag($tag, $userId, int $limit = 0, int $offset = 0) {
+		$query = $this->queryFromOperator(new SearchComparison(ISearchComparison::COMPARE_EQUAL, 'tagname', $tag), $userId, $limit, $offset);
 		return $this->search($query);
 	}