fix small issues in UsersController handling

Signed-off-by: Arthur Schiwon <[email protected]>
nextcloud · Jun 29, 2021 · ff99a05 · ff99a05
1 parent 8d3fb41
commit ff99a05
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 6 deletions.
diff --git a/apps/provisioning_api/lib/Controller/AUserData.php b/apps/provisioning_api/lib/Controller/AUserData.php
@@ -156,7 +156,7 @@ protected function getUserData(string $userId, bool $includeScopes = false): arr
 			foreach ($emailCollection->getProperties() as $property) {
 				$additionalEmails[] = $property->getValue();
 				if ($includeScopes) {
-					$additionalEmailScopes = $property->getScope();
+					$additionalEmailScopes[] = $property->getScope();
 				}
 			}
 			$data[IAccountManager::COLLECTION_EMAIL] = $additionalEmails;

diff --git a/apps/provisioning_api/lib/Controller/UsersController.php b/apps/provisioning_api/lib/Controller/UsersController.php
@@ -673,8 +673,12 @@ public function editUserMultiValue(
 					}
 				}
 				if ($targetProperty instanceof IAccountProperty) {
-					$targetProperty->setScope($value);
-					$this->accountManager->updateAccount($userAccount);
+					try {
+						$targetProperty->setScope($value);
+						$this->accountManager->updateAccount($userAccount);
+					} catch (\InvalidArgumentException $e) {
+						throw new OCSException('', 102);
+					}
 				} else {
 					throw new OCSException('', 102);
 				}

diff --git a/build/integration/features/bootstrap/Provisioning.php b/build/integration/features/bootstrap/Provisioning.php
@@ -168,9 +168,6 @@ public function userHasSetting($user, $settings) {
 		$response = $client->get($fullUrl, $options);
 		foreach ($settings->getRows() as $setting) {
 			$value = json_decode(json_encode(simplexml_load_string($response->getBody())->data->{$setting[0]}), 1);
-			if (in_array($setting[0], ['additional_mail', 'additional_mailScope'], true)) {
-				var_dump($value);
-			}
 			if (isset($value['element']) && in_array($setting[0], ['additional_mail', 'additional_mailScope'], true)) {
 				$expectedValues = explode(';', $setting[1]);
 				foreach ($expectedValues as $expected) {