Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Contacts menu doesn't list users with users that set their display name to "local only" #10317

Closed
MorrisJobke opened this issue Jul 20, 2018 · 6 comments
Closed

Contacts menu doesn't list users with users that set their display name to "local only" #10317

MorrisJobke opened this issue Jul 20, 2018 · 6 comments
Labels
4. to release Ready to be released and/or waiting for tests to finish 26-feedback bug feature: contacts menu
Milestone
Nextcloud 27

Comments

@MorrisJobke
Copy link
Member

Steps

  • having a user1 that sets the display name to "local"
  • login as user2 and check if the user is available
  • actual: the user doesn't show up
  • expected: it shows up

Problem description by @schiessle:

The problem is that we are using the contacts manager to search all users for the contacts menu. This searched only the carddav address books and the local user will be removed if you set the display name to "local" to avoid that it is synced with trusted servers.

The contacts menu should instead of querying the system wide address book the accounts table or to list the users.

cc @ChristophWurst @rullzer @nickvergessen
@nextcloud-bot
Copy link
Member

GitMate.io thinks possibly related issues are #9824 (contacts menu search must NOT show disabled users), #9505 (contacts menu doesn't find / list all users (with external user backend webdav)), #6609 (Contacts with a different display name than the user name are not found when autocompletion is disabled), #4592 (Contacts menu should mention if a user has birthday), and #10296 (Don't fail contacts menu on unkown user).

@nextcloud-bot nextcloud-bot mentioned this issue Aug 16, 2018
Closed
@nextcloud-bot nextcloud-bot mentioned this issue Oct 2, 2018
Closed
This was referenced Oct 12, 2018
Closed
Closed
MorrisJobke added a commit that referenced this issue Nov 16, 2018
@MorrisJobke
Properly name privacy settings for display name and avatar
b0cc929 
This setting was introduced with f489fd9 in #1946. I could not find any hint that this was ever working local only. Thus this should be changed to "private" to properly reflect what it is doing.

Background is that the properties aren't synced to the system address book if the setting is "private".

Fixes #10317

Signed-off-by: Morris Jobke <[email protected]>
@MorrisJobke MorrisJobke mentioned this issue Nov 16, 2018
Closed
@MorrisJobke MorrisJobke self-assigned this Nov 20, 2018
@skjnldsv skjnldsv added the 0. Needs triage Pending check for reproducibility or if it fits our roadmap label Jun 12, 2019
@szaimen

This comment has been minimized.

Sign in to view
@szaimen szaimen closed this as completed May 21, 2021
@MorrisJobke MorrisJobke removed their assignment May 21, 2021
@szaimen szaimen reopened this Jun 25, 2021
@szaimen szaimen added 1. to develop Accepted and waiting to be taken care of feature: federation and removed 0. Needs triage Pending check for reproducibility or if it fits our roadmap labels Aug 8, 2021
@szaimen szaimen mentioned this issue Aug 14, 2021
Closed
@szaimen
Copy link
Contributor

szaimen commented Jan 9, 2023

Hi, please update to 24.0.8 or better 25.0.2 and report back if it fixes the issue. Thank you!

@szaimen szaimen added needs info 0. Needs triage Pending check for reproducibility or if it fits our roadmap and removed 1. to develop Accepted and waiting to be taken care of labels Jan 9, 2023
@nickvergessen nickvergessen added 1. to develop Accepted and waiting to be taken care of and removed needs info 0. Needs triage Pending check for reproducibility or if it fits our roadmap labels Jan 9, 2023
@nickvergessen
Copy link
Member

Still happening

@nickvergessen
Copy link
Member

Also the avatar menu does not work for such users, e.g. @GretaD on our instance

@ChristophWurst
Copy link
Member

Fixed by #38048. Local contacts are now persisted. cc @miaulalala

@ChristophWurst ChristophWurst added 4. to release Ready to be released and/or waiting for tests to finish and removed 1. to develop Accepted and waiting to be taken care of labels May 22, 2023
@ChristophWurst ChristophWurst added this to the Nextcloud 27 milestone May 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
4. to release Ready to be released and/or waiting for tests to finish 26-feedback bug feature: contacts menu
Projects
None yet
Milestone
Nextcloud 27
Development

No branches or pull requests
6 participants
@nickvergessen @MorrisJobke @ChristophWurst @skjnldsv @nextcloud-bot @szaimen