Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjust message "This server has no working Internet connection" #181

Closed
jernst opened this issue Jun 20, 2016 · 6 comments
Closed

Adjust message "This server has no working Internet connection" #181

jernst opened this issue Jun 20, 2016 · 6 comments
Labels
good first issue Small tasks with clear documentation about how and in which place you need to fix things in.

Comments

@jernst
Copy link
Contributor

jernst commented Jun 20, 2016

Setup:

  • Mac behind a NAT router/firewall
  • runs Arch Linux in VirtualBox, virtual network interface bridged (i.e. it got its own IP address 192.168.1.144 from the NAT router/firewall)
  • inside, running UBOS development version in a container started with systemd-nspawn -n (i.e. system sets up its own private network and NAT, container is at 10.0.0.2/28)
  • running NextCloud in that UBOS container.

Nextcloud reports: "This server has no working Internet connection". That appears to be incorrect:

> traceroute github.com
1  gateway (10.0.0.1)  0.071 ms  0.013 ms  0.010 ms
2  xxx (192.168.1.1)  0.507 ms  0.454 ms  0.422 ms
3  comcast outside host ... and so forth

DNS is also configured correctly:

> host github.com
github.com has address 192.30.252.128

It seems that detection code might be a bit too aggressive.

@MorrisJobke
Copy link
Member

All what the internet check does is:

  • connect to https://owncloud.org/
  • connect to http://owncloud.org/

If there is no error happening, then the connection is working. I will prepare a log output to give you maybe a hint, what happened.

@MorrisJobke
Copy link
Member

For more details add following code between those lines:

} catch (\Exception $e) {
return false;

\OC::$server->getLogger()->logException($e, ['app' => 'internet_connection_check']);

@MorrisJobke MorrisJobke self-assigned this Jun 21, 2016
@MorrisJobke
Copy link
Member

Then open the admin page again and check the log. Beside that it could also be the case, that the config.php option has_internet_connection is set to false.

@jernst
Copy link
Contributor Author

jernst commented Jun 21, 2016

It works today. Given your explanation, perhaps owncloud.org was temporarily down yesterday. Can I suggest to modify the error message to: "This server has no working Internet connection: it cannot reach http://owncloud.org/", in which I would have known what it attempted to do and figured out myself without logging a bug :-)

@MorrisJobke
Copy link
Member

Can I suggest to modify the error message to: "This server has no working Internet connection: it cannot reach http://owncloud.org/", in which I would have known what it attempted to do and figured out myself without logging a bug :-)

Makes sense :)

@MorrisJobke MorrisJobke added good first issue Small tasks with clear documentation about how and in which place you need to fix things in. and removed needs info labels Jun 21, 2016
@MorrisJobke MorrisJobke changed the title Incorrect "This server has no working Internet connection" Adjust message "This server has no working Internet connection" Jun 21, 2016
KittieCrash added a commit to KittieCrash/server that referenced this issue Jul 11, 2016
KittieCrash added a commit to KittieCrash/server that referenced this issue Jul 11, 2016
@KittieCrash
Copy link
Contributor

Hey guys, let me know if #374 looks suitable.

KittieCrash added a commit to KittieCrash/server that referenced this issue Jul 14, 2016
Changes Internet Connection Test to use https://nextcloud.org

Adds new sites to Server Internet Check. Check now uses OR logic.
KittieCrash added a commit to KittieCrash/server that referenced this issue Jul 15, 2016
KittieCrash added a commit to KittieCrash/server that referenced this issue Jul 15, 2016
KittieCrash added a commit to KittieCrash/server that referenced this issue Jul 21, 2016
williambargent pushed a commit that referenced this issue Jul 21, 2016
Alters 'No Internet Connection' error message. #181
@MorrisJobke MorrisJobke removed their assignment Sep 5, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Small tasks with clear documentation about how and in which place you need to fix things in.
Projects
None yet
Development

No branches or pull requests

3 participants