Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Theming app: Change page title to configured name #341

Closed
mtraeger opened this issue Jul 7, 2016 · 4 comments · Fixed by #371
Closed

Theming app: Change page title to configured name #341

mtraeger opened this issue Jul 7, 2016 · 4 comments · Fixed by #371
Assignees
@LukasReschke
Labels
enhancement feature: theming

Comments

@mtraeger
Copy link

mtraeger commented Jul 7, 2016

For the Theming feature it might be interesting to exchange also the HTML page tile with the new name. At the moment there is Nextcloud or <App> - Nextcloud.

<Name> or <App> - <Name> might be interesting for some users.
@MorrisJobke
Copy link
Member

@schiessle @LukasReschke

@LukasReschke LukasReschke self-assigned this Jul 8, 2016
@nickvergessen
Copy link
Member

I'd even say this is a bug, I expected the Name option to do that. Took me a while to discover that it only changes the text in the footer.

LukasReschke added a commit that referenced this issue Jul 11, 2016
@LukasReschke
Implement "getTitle"
0fd7707 
Fixes #341
@LukasReschke LukasReschke mentioned this issue Jul 11, 2016
Merged
LukasReschke added a commit that referenced this issue Jul 11, 2016
@LukasReschke
Implement "getTitle"
573f9e1 
Fixes #341
@LukasReschke LukasReschke mentioned this issue Jul 11, 2016
Merged
MorrisJobke pushed a commit that referenced this issue Jul 11, 2016
@LukasReschke @MorrisJobke
Implement "getTitle" (#372)
450926e 
Fixes #341
KittieCrash pushed a commit to KittieCrash/server that referenced this issue Jul 15, 2016
@LukasReschke @KittieCrash
Implement "getTitle"
296eaab 
Fixes nextcloud#341
@fancycode
Copy link
Member

fancycode commented Jun 13, 2017 •
edited
Loading

I guess I'm a bit late to the party, but this causes some confusion with custom themes where you can implement a getTitle method - which was used for the page title before (NC 10 and 11).
Now with NC 12 the getName is used and the getTitle is ignored. With that, I can no longer just change the page title to my custom string and keep Nextcloud everywhere else...

@fancycode
Copy link
Member

Reading the changes more, this is probably not the issue where my problem was introduced - sorry for the noise, will open a new one.

@gloomytrousers gloomytrousers mentioned this issue Jan 27, 2019
Closed
@snyk-bot snyk-bot mentioned this issue Dec 23, 2020
Open
@gmright2 gmright2 mentioned this issue Feb 12, 2021
Open
This was referenced Sep 5, 2021
Open
Open
This was referenced Jan 12, 2022
Open
Open
This was referenced Feb 9, 2022
Open
Open
@Jessi1983 Jessi1983 mentioned this issue Jun 18, 2023
Open
@kaocher82 kaocher82 mentioned this issue Oct 27, 2023
Open
@gisforgirard gisforgirard mentioned this issue Oct 27, 2023
Open
@AveryPalmer AveryPalmer mentioned this issue Oct 28, 2023
Open
@Jessi1983 Jessi1983 mentioned this issue Oct 28, 2023
Open
@gisforgirard gisforgirard mentioned this issue Dec 14, 2023
Open
@Jessi1983 Jessi1983 mentioned this issue Dec 14, 2023
Open
@AveryPalmer AveryPalmer mentioned this issue Dec 14, 2023
Open
@kaocher82 kaocher82 mentioned this issue Dec 15, 2023
Open
@gisforgirard gisforgirard mentioned this issue Jan 5, 2024
Open
@kaocher82 kaocher82 mentioned this issue Jan 5, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@LukasReschke LukasReschke

Labels
enhancement feature: theming
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Implement "getTitle" nextcloud/server
5 participants
@nickvergessen @MorrisJobke @fancycode @LukasReschke @mtraeger