Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BITV]: Replace "Transfer" button with NcVue button #42593

Closed
JuliaKirschenheuter opened this issue Jan 5, 2024 · 2 comments · Fixed by #42690
Closed

[BITV]: Replace "Transfer" button with NcVue button #42593

JuliaKirschenheuter opened this issue Jan 5, 2024 · 2 comments · Fixed by #42690
Assignees
Labels
1. to develop Accepted and waiting to be taken care of accessibility

Comments

@JuliaKirschenheuter
Copy link
Contributor

Contrast issue, html valid elements issue.

Replace <input data-v-67866491="" type="submit" disabled="disabled" class="primary" value="Transfer"> with NcVue button.

Screenshot from 2024-01-05 11-21-52

@JuliaKirschenheuter JuliaKirschenheuter added 1. to develop Accepted and waiting to be taken care of accessibility labels Jan 5, 2024
@emoral435 emoral435 self-assigned this Jan 5, 2024
@emoral435
Copy link
Contributor

Just to know before I submit a PR, I tested replacing the input element with our own NcButton component and kept the logic being the same, however, we still run into the issue of color contrast whenever the button is disabled:
firefox_4jwPcGfbWy
Should we change the contrast between the button when it is disabled? So, should we change the actual component, or should I just add styling to this specific component on this view? @JuliaKirschenheuter

@JuliaKirschenheuter
Copy link
Contributor Author

Dear @emoral435

If you have replaced input with NcButton then it is all right. I haven't seen that this button is disabled. Contrasts are not important for disabled elements. You can push your changes without any styling changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1. to develop Accepted and waiting to be taken care of accessibility
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants