-
-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(files): switched native input to NcButton #42690
Merged
emoral435
merged 2 commits into
master
from
fix/core/42593/replace-transfer-button-with-NcVue-Button
Jan 10, 2024
Merged
fix(files): switched native input to NcButton #42690
emoral435
merged 2 commits into
master
from
fix/core/42593/replace-transfer-button-with-NcVue-Button
Jan 10, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emoral435
requested review from
susnux,
JuliaKirschenheuter,
Pytal and
ShGKme
January 10, 2024 18:13
emoral435
force-pushed
the
fix/core/42593/replace-transfer-button-with-NcVue-Button
branch
from
January 10, 2024 18:17
62d1398
to
ea79f36
Compare
/backport 86a8e07 to stable28 |
Pytal
reviewed
Jan 10, 2024
Signed-off-by: Eduardo Morales <[email protected]>
Signed-off-by: Eduardo Morales <[email protected]>
emoral435
force-pushed
the
fix/core/42593/replace-transfer-button-with-NcVue-Button
branch
from
January 10, 2024 18:29
ea79f36
to
2f94cca
Compare
ShGKme
approved these changes
Jan 10, 2024
Pytal
approved these changes
Jan 10, 2024
emoral435
deleted the
fix/core/42593/replace-transfer-button-with-NcVue-Button
branch
January 10, 2024 19:14
The backport to stable28 failed. Please do this backport manually. # Switch to the target branch and update it
git checkout stable28
git pull origin stable28
# Create the new backport branch
git checkout -b fix/foo-stable28
# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts. Resolve them.
git cherry-pick abc123
# Push the cherry pick commit to the remote repository and open a pull request
git push origin fix/foo-stable28 Error: Unknown error More info at https://docs.nextcloud.com/server/latest/developer_manual/getting_started/development_process.html#manual-backport |
/skjnldsv-backport to stable28 |
2 tasks
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Replaces the 'input' button to transfer files / ownership with our native NcButton component
New DOM Update View
Checklist