Enable sabre/dav's locking feature [feature request]

[jdinkel]

sabre/dav already supports webdav file locking, with instructions for enabling it here: http://sabre.io/dav/locks/

I would like for this to be enabled in Nextcloud, so webdav clients can make use of file locking.

Other than getting overwritten by the next update, would there be any unforeseen consequences if I just added the lines from that webpage to /var/www/nextcloud/apps/dav/appinfo/v1/webdav.php ?

[MorrisJobke]

Related to owncloud/core#31651

[MorrisJobke]

@rullzer @icewind1991 Opinions?

[rullzer]

I'm not a fan of locking like this. For several reasons.

1. Not all webdav clients support locking. Sure we should fall back to a read only state then but still.
2. You always have the question when to break the lock? If you turn of your laptop and you still have a lock on some file/folder. Then when do you break this lock?

[rullzer]

@jdinkel as to answer your question. There are still endpoints that do not use webdav. So then this locking won't be obeyed. Or in that case if you use the new endpoint.

[icewind1991]

Also note that sabre's built in locking implementation wont work properly since it doesn't take things like shares into account

[MorrisJobke]

Let's close this as duplicate of #1308

[jdinkel]

Oh sorry I missed that open #1308. I think I was searching specific to sabredav.

Also I was aware it wouldn't be a completely proper working licking solution, but would at least be better than nothing. As it is, people using webdav can overwrite each other's work, and people using other endpoints can overwrite each other's work. With sabredav's locking enabled then at least webdav clients are protected from each other and other endpoints still risk overwriting work but that is just the same situation as before.

So the webdav situation would be improved and the other endpoints would be a problem but that is the same problem we have anyway, if I understand correctly.

[nobe80]

I completly agress with jdinkel

Oh sorry I missed that open #1308. I think I was searching specific to sabredav.

Also I was aware it wouldn't be a completely proper working licking solution, but would at least be better than nothing. As it is, people using webdav can overwrite each other's work, and people using other endpoints can overwrite each other's work. With sabredav's locking enabled then at least webdav clients are protected from each other and other endpoints still risk overwriting work but that is just the same situation as before.

So the webdav situation would be improved and the other endpoints would be a problem but that is the same problem we have anyway, if I understand correctly.

i completly agress with you for WebDAV User. Apps like temporary file lock are not a solution for Users that are not using the Webinterface. To log in, set a lock in webinterface and unlock it again is absolutly not practicable!
Can you tell me if it works with modifying the sabre config?